upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor synced 2025-05-21 16:40:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix artifact page bug (#19807)

Browse Source 
* fix artifact page bug

* update testcase
This commit is contained in:
ShengqiWang 2024-01-15 14:09:56 +08:00 committed by GitHub
parent eb125419cc
commit 04a140332e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/portal/src/app/base/project/repository/artifact/artifact-list-page/artifact-list/artifact-list-tab/artifact-filter/artifact-filter.component.html
View File

@ -83,6 +83,7 @@
(clickLabel)="selectValue($event)"
[scope]="'p'"
[projectId]="projectId"
[dropdownOpened]="dropdownOpened"
[width]="200"
[ownedLabels]="getSelectLabel()">
</app-label-selector>

2
src/portal/src/app/shared/components/label-selector/label-selector.component.spec.ts
View File

@ -59,6 +59,6 @@ describe('LabelSelectorComponent', () => {
fixture.detectChanges();
await fixture.whenStable();
const checkIcon = fixture.nativeElement.querySelector('.check-icon');
expect(checkIcon.style.visibility).toEqual('visible');
expect(checkIcon.style.visibility).toEqual('hidden');
});
});

4
src/portal/src/app/shared/components/label-selector/label-selector.component.ts
View File

@ -41,6 +41,8 @@ export class LabelSelectorComponent implements OnInit, OnChanges, OnDestroy {
scope: string = GLOBAL; // 'g' for global and 'p' for project, default 'g'
@Input()
projectId: number; // if scope = 'p', projectId is required
@Input()
dropdownOpened: boolean; // parent component opened status
candidateLabels: Label[] = [];
searchValue: string;
loading: boolean = false;
@ -159,7 +161,7 @@ export class LabelSelectorComponent implements OnInit, OnChanges, OnDestroy {
isSelect(label: Label): boolean {
if (this.ownedLabels?.length) {
return this.ownedLabels.some(item => {
return item.id === label.id;
return item.id === label.id && this.dropdownOpened;
});
}
return false;