upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor synced 2024-09-20 14:35:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: skip db tx for get, head and options api requests (#14837)

Browse Source 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
This commit is contained in:
He Weiwei 2021-05-11 10:54:15 +08:00 committed by GitHub
parent e006f4bab5
commit 0d7250f83d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/middlewares/middlewares.go
View File

@ -15,7 +15,6 @@
package middlewares package middlewares
import ( import (
"github.com/goharbor/harbor/src/lib"
"net/http" "net/http"
"regexp" "regexp"
@ -43,17 +42,18 @@ var (
// which will make ping request timeout, so skip the middlewares which will require DB conn. // which will make ping request timeout, so skip the middlewares which will require DB conn.
pingSkipper = middleware.MethodAndPathSkipper(http.MethodGet, match("^/api/v2.0/ping")) pingSkipper = middleware.MethodAndPathSkipper(http.MethodGet, match("^/api/v2.0/ping"))
// dbTxSkippers skip the transaction middleware for GET Blob, PATCH Blob Upload and PUT Blob Upload APIs // dbTxSkippers skip the transaction middleware for PATCH Blob Upload, PUT Blob Upload and `Read` APIs
// because the APIs may take a long time to run, enable the transaction middleware in them will hold the database connections // because the APIs may take a long time to run, enable the transaction middleware in them will hold the database connections
// until the API finished, this behavior may eat all the database connections. // until the API finished, this behavior may eat all the database connections.
// There are no database writing operations in the GET Blob and PATCH Blob APIs, so skip the transaction middleware is all ok. // There are no database writing operations in the PATCH Blob APIs, so skip the transaction middleware is all ok.
// For the PUT Blob Upload API, we will make a transaction manually to write blob info to the database when put blob upload successfully. // For the PUT Blob Upload API, we will make a transaction manually to write blob info to the database when put blob upload successfully.
dbTxSkippers = []middleware.Skipper{ dbTxSkippers = []middleware.Skipper{
middleware.MethodAndPathSkipper(http.MethodGet, distribution.BlobURLRegexp),
middleware.MethodAndPathSkipper(http.MethodPatch, distribution.BlobUploadURLRegexp), middleware.MethodAndPathSkipper(http.MethodPatch, distribution.BlobUploadURLRegexp),
middleware.MethodAndPathSkipper(http.MethodPut, distribution.BlobUploadURLRegexp), middleware.MethodAndPathSkipper(http.MethodPut, distribution.BlobUploadURLRegexp),
middleware.MethodAndPathSkipper(http.MethodGet, lib.V2CatalogURLRe), func(r *http.Request) bool { // skip tx for GET, HEAD and Options requests
pingSkipper, m := r.Method
return m == http.MethodGet || m == http.MethodHead || m == http.MethodOptions
},
} }
// readonlySkippers skip the post request when harbor sets to readonly. // readonlySkippers skip the post request when harbor sets to readonly.