upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor synced 2025-04-20 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

GC: correctly handle manifest unknown (404) condition in v2DeleteManifest retry loop (#18386)

Browse Source 
GC: handle manifest unknown (404) during V2 manifest delete retry loop

Signed-off-by: Danny Kulchinsky <dkulchinsky@fastly.com>
This commit is contained in:
Danny Kulchinsky 2023-04-12 16:52:52 -04:00 committed by GitHub
parent b201f9864f
commit 14e4c07d94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/jobservice/job/impl/gc/util.go
View File

@ -62,6 +62,10 @@ func v2DeleteManifest(logger logger.Interface, repository, digest string) error
if err == readonly.Err {
return retry.Abort(err)
}
// If delete returned an err because the manifest is unknown, consider success
if errors.IsNotFoundErr(err) {
return nil
}
return err
}, retry.Callback(func(err error, sleep time.Duration) {
logger.Infof("failed to exec v2DeleteManifest, error: %v, will retry again after: %s", err, sleep)