From 15ad870262fcb92d3f53041df4889138bf72ea53 Mon Sep 17 00:00:00 2001 From: DQ Date: Fri, 29 Jan 2021 18:07:06 +0800 Subject: [PATCH] Fix: unkonw metrics issue Signed-off-by: DQ --- src/server/middleware/metric/metric.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/server/middleware/metric/metric.go b/src/server/middleware/metric/metric.go index 802b3dee2..71f730af0 100644 --- a/src/server/middleware/metric/metric.go +++ b/src/server/middleware/metric/metric.go @@ -49,11 +49,13 @@ func instrumentHandler(next http.Handler) http.Handler { now, rc, op := time.Now(), lib.NewResponseRecorder(w), "" ctx := context.WithValue(r.Context(), contextOpIDKey{}, &op) next.ServeHTTP(rc, r.WithContext(ctx)) - if len(op) == 0 && isChartMuseumURL(r.URL.Path) { - op = "chartmuseum" - } else { - // From swagger's perspective the operation of this legacy URL is unknown - op = "unknown" + if len(op) == 0 { + if isChartMuseumURL(r.URL.Path) { + op = "chartmuseum" + } else { + // From swagger's perspective the operation of this legacy URL is unknown + op = "unknown" + } } metric.TotalReqDurSummary.WithLabelValues(r.Method, op).Observe(time.Since(now).Seconds()) metric.TotalReqCnt.WithLabelValues(r.Method, strconv.Itoa(rc.StatusCode), op).Inc()