Merge pull request #819 from ywk253100/fix_for_#761

Fix #761

api/member.go

@@ -142,13 +142,22 @@ func (pma *ProjectMemberAPI) Post() {
 		return
 	}
 
-	for _, rid := range req.Roles {
-		err = dao.AddProjectMember(projectID, userID, int(rid))
-		if err != nil {
-			log.Errorf("Failed to update DB to add project user role, project id: %d, user id: %d, role id: %d", projectID, userID, rid)
-			pma.RenderError(http.StatusInternalServerError, "Failed to update data in database")
-			return
-		}
+	if len(req.Roles) <= 0 || len(req.Roles) > 1 {
+		pma.CustomAbort(http.StatusBadRequest, "only one role is supported")
+	}
+
+	rid := req.Roles[0]
+	if !(rid == models.PROJECTADMIN ||
+		rid == models.DEVELOPER ||
+		rid == models.GUEST) {
+		pma.CustomAbort(http.StatusBadRequest, "invalid role")
+	}
+
+	err = dao.AddProjectMember(projectID, userID, rid)
+	if err != nil {
+		log.Errorf("Failed to update DB to add project user role, project id: %d, user id: %d, role id: %d", projectID, userID, rid)
+		pma.RenderError(http.StatusInternalServerError, "Failed to update data in database")
+		return
 	}
 }
 

docs/swagger.yaml

@@ -314,7 +314,7 @@ paths:
           description: Relevant project ID.
         - name: roles
           in: body
-          description: Role members for adding to relevant project.
+          description: Role members for adding to relevant project. Only one role is supported in the role list.
           schema:
             $ref: '#/definitions/RoleParam'
       tags: