upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor synced 2024-09-20 14:45:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent copying artifact to a proxy cache project

Browse Source 
Prevent copying artifact to a proxy cache project

Signed-off-by: Wenkai Yin <yinw@vmware.com>
This commit is contained in:
Wenkai Yin 2020-07-17 15:24:18 +08:00
parent af3a638980
commit 54a1155140
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
api/v2.0/swagger.yaml
View File

@ -228,6 +228,8 @@ paths:
$ref: '#/responses/403' $ref: '#/responses/403'
'404': '404':
$ref: '#/responses/404' $ref: '#/responses/404'
'405':
$ref: '#/responses/405'
'500': '500':
$ref: '#/responses/500' $ref: '#/responses/500'
/projects/{project_name}/repositories/{repository_name}/artifacts/{reference}: /projects/{project_name}/repositories/{repository_name}/artifacts/{reference}:
@ -1323,6 +1325,14 @@ responses:
type: string type: string
schema: schema:
$ref: '#/definitions/Errors' $ref: '#/definitions/Errors'
'405':
description: Method not allowed
headers:
X-Request-Id:
description: The ID of the corresponding request for the response
type: string
schema:
$ref: '#/definitions/Errors'
'409': '409':
description: Conflict description: Conflict
headers: headers:

12
src/server/v2.0/handler/artifact.go
View File

@ -18,6 +18,7 @@ import (
"context" "context"
"fmt" "fmt"
"github.com/goharbor/harbor/src/controller/event/metadata" "github.com/goharbor/harbor/src/controller/event/metadata"
"github.com/goharbor/harbor/src/controller/project"
"github.com/goharbor/harbor/src/pkg/notification" "github.com/goharbor/harbor/src/pkg/notification"
"net/http" "net/http"
"strings" "strings"
@ -48,6 +49,7 @@ const (
func newArtifactAPI() *artifactAPI { func newArtifactAPI() *artifactAPI {
return &artifactAPI{ return &artifactAPI{
artCtl: artifact.Ctl, artCtl: artifact.Ctl,
proCtl: project.Ctl,
repoCtl: repository.Ctl, repoCtl: repository.Ctl,
scanCtl: scan.DefaultController, scanCtl: scan.DefaultController,
tagCtl: tag.Ctl, tagCtl: tag.Ctl,
@ -57,6 +59,7 @@ func newArtifactAPI() *artifactAPI {
type artifactAPI struct { type artifactAPI struct {
BaseAPI BaseAPI
artCtl artifact.Controller artCtl artifact.Controller
proCtl project.Controller
repoCtl repository.Controller repoCtl repository.Controller
scanCtl scan.Controller scanCtl scan.Controller
tagCtl tag.Controller tagCtl tag.Controller
@ -152,6 +155,15 @@ func (a *artifactAPI) CopyArtifact(ctx context.Context, params operation.CopyArt
return a.SendError(ctx, err) return a.SendError(ctx, err)
} }
pro, err := a.proCtl.GetByName(ctx, params.ProjectName)
if err != nil {
return a.SendError(ctx, err)
}
if pro.RegistryID > 0 {
return a.SendError(ctx, errors.New(nil).WithCode(errors.MethodNotAllowedCode).
WithMessage("cannot copy the artifact to a proxy cache project"))
}
srcRepo, ref, err := parse(params.From) srcRepo, ref, err := parse(params.From)
if err != nil { if err != nil {
return a.SendError(ctx, err) return a.SendError(ctx, err)