upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor synced 2024-09-21 10:42:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refacotor the disable property on delete version

Browse Source 
Extract code in property to a function

Signed-off-by: Qian Deng <dengq@vmware.com>
This commit is contained in:
Qian Deng 2018-08-20 12:41:55 +08:00
parent 5e95ab3cd8
commit 75533bfc40
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ui_ng/lib/src/helm-chart/versions/helm-chart-version.component.html
View File

@ -42,7 +42,7 @@
(click)="versionDownload()">
<clr-icon shape="download" size="16"></clr-icon>&nbsp;{{'HELM_CHART.DOWNLOAD' | translate}}</button>
<button type="button" class="btn btn-sm btn-secondary"
[disabled]="selectedRows.length<=0 || !hasProjectAdminRole"
[disabled]="!canDeleteVersionOnList()"
(click)="openVersionDeleteModal(selectedRows)">
<clr-icon shape="times" size="16"></clr-icon>&nbsp;{{'BUTTON.DELETE' | translate}}</button>
</clr-dg-action-bar>
@ -111,7 +111,7 @@
<button type="button" class="btn btn-link"
(click)="versionDownload($event, item)">{{'HELM_CHART.DOWNLOAD' | translate}}</button>
<button type="button" class="btn btn-link"
[disabled]="selectedRows.length<=0 || !hasProjectAdminRole"
[disabled]="!canDeleteVersionOnCard()"
(click)="deleteVersionCard($event, item)">{{'BUTTON.DELETE' | translate}}</button>
</clr-dropdown>
</div>

8
src/ui_ng/lib/src/helm-chart/versions/helm-chart-version.component.ts
View File

@ -290,4 +290,12 @@ export class ChartVersionComponent implements OnInit {
return "HELM_CHART.ACTIVE";
}
}
canDeleteVersionOnCard() {
return this.hasProjectAdminRole;
}
canDeleteVersionOnList() {
return this.selectedRows.length > 0 && this.hasProjectAdminRole;
}
}