upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor synced 2024-09-20 15:45:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13406 from mmpei/offical-replicate-chart-fix-20201031

Browse Source 
fix chart replication issue of uppercase letters
This commit is contained in:
Wenkai Yin(尹文开) 2020-11-03 10:55:40 +08:00 committed by GitHub
commit 99d818f4db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/replication/adapter/harbor/base/chart_registry.go
View File

@ -26,6 +26,7 @@ import (
common_http "github.com/goharbor/harbor/src/common/http"
"github.com/goharbor/harbor/src/replication/filter"
"github.com/goharbor/harbor/src/replication/model"
"net/url"
)
type label struct {
@ -151,16 +152,21 @@ func (a *Adapter) DownloadChart(name, version string) (io.ReadCloser, error) {
if info.Metadata == nil || len(info.Metadata.URLs) == 0 || len(info.Metadata.URLs[0]) == 0 {
return nil, fmt.Errorf("cannot got the download url for chart %s:%s", name, version)
}
url := strings.ToLower(info.Metadata.URLs[0])
url, err := url.Parse(info.Metadata.URLs[0])
if err != nil {
return nil, err
}
// relative URL
if !(strings.HasPrefix(url, "http://") || strings.HasPrefix(url, "https://")) {
urlStr := url.String()
if !(url.Scheme == "http" || url.Scheme == "https") {
project, _, err := parseChartName(name)
if err != nil {
return nil, err
}
url = fmt.Sprintf("%s/chartrepo/%s/%s", a.Client.GetURL(), project, url)
urlStr = fmt.Sprintf("%s/chartrepo/%s/%s", a.Client.GetURL(), project, urlStr)
}
req, err := http.NewRequest(http.MethodGet, url, nil)
req, err := http.NewRequest(http.MethodGet, urlStr, nil)
if err != nil {
return nil, err
}