From a50f782bebd456cff22bd889aab3d1311efda159 Mon Sep 17 00:00:00 2001 From: ChenYu Zhang Date: Thu, 20 May 2021 15:52:53 +0800 Subject: [PATCH] fix: change sql to improve the performance of catalog api (#14820) Signed-off-by: chlins --- src/pkg/repository/dao/dao.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/pkg/repository/dao/dao.go b/src/pkg/repository/dao/dao.go index 68f48b3b6..9631a8180 100644 --- a/src/pkg/repository/dao/dao.go +++ b/src/pkg/repository/dao/dao.go @@ -16,7 +16,6 @@ package dao import ( "context" - "fmt" "time" o "github.com/astaxie/beego/orm" @@ -160,7 +159,7 @@ func (d *dao) NonEmptyRepos(ctx context.Context) ([]*model.RepoRecord, error) { return nil, err } - sql := fmt.Sprintf(`select distinct r.* from repository as r LEFT JOIN tag as t on r.repository_id = t.repository_id where t.repository_id is not null;`) + sql := `select * from repository where repository_id in (select distinct repository_id from tag)` _, err = ormer.Raw(sql).QueryRows(&repos) if err != nil { return repos, err