From a9063d240d56670b7cb7ba4d8578ee79199f4f9b Mon Sep 17 00:00:00 2001
From: Shijun Sun <30999793+AllForNothing@users.noreply.github.com>
Date: Wed, 25 May 2022 10:43:29 +0800
Subject: [PATCH] Modify HarborDatetimePipe to pure pipe to improve performance
 (#16906)

Signed-off-by: AllForNothing <sshijun@vmware.com>
---
 .../components/navigator/navigator.component.html      |  1 -
 .../shared/components/navigator/navigator.component.ts |  2 ++
 .../src/app/shared/pipes/harbor-datetime.pipe.ts       |  2 +-
 src/portal/src/app/shared/units/shared.utils.ts        | 10 ++--------
 4 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/portal/src/app/shared/components/navigator/navigator.component.html b/src/portal/src/app/shared/components/navigator/navigator.component.html
index 81faa6e59..c36c6d563 100644
--- a/src/portal/src/app/shared/components/navigator/navigator.component.html
+++ b/src/portal/src/app/shared/components/navigator/navigator.component.html
@@ -1,7 +1,6 @@
 <clr-header class="header-5 header" [attr.style]="getBgColor()">
     <div class="branding">
         <a href="javascript:void(0)" class="nav-link" (click)="homeAction()">
-            <!-- <clr-icon shape="vm-bug"  *ngIf="!customStyle?.headerLogo"></clr-icon> -->
             <img
                 [attr.src]="'images/' + customStyle?.product?.logo"
                 *ngIf="customStyle?.product?.logo; else elseBlock"
diff --git a/src/portal/src/app/shared/components/navigator/navigator.component.ts b/src/portal/src/app/shared/components/navigator/navigator.component.ts
index c64af8479..9e48b9bd4 100644
--- a/src/portal/src/app/shared/components/navigator/navigator.component.ts
+++ b/src/portal/src/app/shared/components/navigator/navigator.component.ts
@@ -192,6 +192,8 @@ export class NavigatorComponent implements OnInit {
             DEFAULT_DATETIME_RENDERING_LOCALSTORAGE_KEY,
             datetime
         );
+        // have to reload,as HarborDatetimePipe is pure pipe
+        window.location.reload();
     }
 
     // Handle the home action
diff --git a/src/portal/src/app/shared/pipes/harbor-datetime.pipe.ts b/src/portal/src/app/shared/pipes/harbor-datetime.pipe.ts
index 7115b6b97..0b9add583 100644
--- a/src/portal/src/app/shared/pipes/harbor-datetime.pipe.ts
+++ b/src/portal/src/app/shared/pipes/harbor-datetime.pipe.ts
@@ -22,7 +22,7 @@ const formatTransformers: Record<
 
 @Pipe({
     name: 'harborDatetime',
-    pure: false,
+    pure: true,
 })
 export class HarborDatetimePipe implements PipeTransform {
     transform(value: any, format?: string): string {
diff --git a/src/portal/src/app/shared/units/shared.utils.ts b/src/portal/src/app/shared/units/shared.utils.ts
index 98e96d752..ef3dd1851 100644
--- a/src/portal/src/app/shared/units/shared.utils.ts
+++ b/src/portal/src/app/shared/units/shared.utils.ts
@@ -297,16 +297,10 @@ export function getDatetimeRendering(): DatetimeRendering {
     const savedDatetimeRendering = localStorage.getItem(
         DEFAULT_DATETIME_RENDERING_LOCALSTORAGE_KEY
     );
-    if (isDatetimeRendering(savedDatetimeRendering)) {
+    if (savedDatetimeRendering && isDatetimeRendering(savedDatetimeRendering)) {
         return savedDatetimeRendering;
-    } else {
-        console.warn(
-            `Invalid saved datetime rendering setting ${JSON.stringify(
-                savedDatetimeRendering
-            )}; defaulting to ${JSON.stringify(DefaultDatetimeRendering)}.`
-        );
-        return DefaultDatetimeRendering;
     }
+    return DefaultDatetimeRendering;
 }
 
 function isDatetimeRendering(x: unknown): x is DatetimeRendering {