diff --git a/src/common/dao/clair.go b/src/common/dao/clair.go index e2343b11f..170a038e8 100644 --- a/src/common/dao/clair.go +++ b/src/common/dao/clair.go @@ -49,6 +49,6 @@ func SetClairVulnTimestamp(namespace string, timestamp time.Time) error { func ListClairVulnTimestamps() ([]*models.ClairVulnTimestamp, error) { var res []*models.ClairVulnTimestamp o := GetOrmer() - _, err := o.QueryTable(models.ClairVulnTimestampTable).All(&res) + _, err := o.QueryTable(models.ClairVulnTimestampTable).Limit(-1).All(&res) return res, err } diff --git a/src/common/dao/repository.go b/src/common/dao/repository.go index fc6f75fbf..ee9533417 100644 --- a/src/common/dao/repository.go +++ b/src/common/dao/repository.go @@ -51,7 +51,7 @@ func GetRepositoryByName(name string) (*models.RepoRecord, error) { func GetAllRepositories() ([]*models.RepoRecord, error) { o := GetOrmer() var repos []*models.RepoRecord - _, err := o.QueryTable("repository"). + _, err := o.QueryTable("repository").Limit(-1). OrderBy("Name").All(&repos) return repos, err } diff --git a/src/common/dao/repository_test.go b/src/common/dao/repository_test.go index ff457aeac..9a0394329 100644 --- a/src/common/dao/repository_test.go +++ b/src/common/dao/repository_test.go @@ -16,6 +16,7 @@ package dao import ( "fmt" + "strconv" "testing" "github.com/stretchr/testify/require" @@ -220,6 +221,40 @@ func TestGetRepositoriesByProject(t *testing.T) { t.Errorf("repository %s not found", repoName) } +func TestGetAllRepositories(t *testing.T) { + var reposBefore []*models.RepoRecord + reposBefore, err := GetAllRepositories() + if err != nil { + t.Fatalf("error occurred while getting all registories. %v", err) + return + } + allBefore := len(reposBefore) + + for i := 0; i < 1200; i++ { + end := strconv.Itoa(i) + repoRecord := models.RepoRecord{ + Name: "test" + end, + ProjectID: 1, + } + if err := AddRepository(repoRecord); err != nil { + t.Fatalf("Error happens when adding the repository: %v", err) + return + } + } + + var reposAfter []*models.RepoRecord + reposAfter, err2 := GetAllRepositories() + if err2 != nil { + t.Fatalf("error occurred while getting all registories. %v", err2) + return + } + allAfter := len(reposAfter) + + if allAfter != allBefore+1200 { + t.Errorf("unexpected total: %d != %d", allAfter, allBefore+1200) + } +} + func addRepository(repository *models.RepoRecord) error { return AddRepository(*repository) } diff --git a/src/common/dao/user.go b/src/common/dao/user.go index c5ad66f8f..a2d4fd68d 100644 --- a/src/common/dao/user.go +++ b/src/common/dao/user.go @@ -102,7 +102,7 @@ func GetTotalOfUsers(query *models.UserQuery) (int64, error) { // ListUsers lists all users according to different conditions. func ListUsers(query *models.UserQuery) ([]models.User, error) { users := []models.User{} - _, err := userQueryConditions(query). + _, err := userQueryConditions(query).Limit(-1). OrderBy("username"). All(&users) return users, err