upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-18 17:03:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

log/windows: Ignore failure to attach or allocate a console

Browse Source 
Wine as of version 4.21 just refuses and goes ERROR_ACCESS_DENIED when
trying to allocate a console for a GUI subsystem application. Why? Who
knows. It does have the functionality to run console applications either
using ncurses or its own console implementation, but it won't. It's best
not to dwell on it and just ignore what's supposed to be the unlikeliest
worst case scenario.
This commit is contained in:
Iris Morelle 2020-01-12 21:41:24 -03:00
parent 15cd351c6b
commit 0cdcb9f8e4
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/log_windows.cpp
View File

@ -421,8 +421,12 @@ void log_file_manager::enable_native_console_output()
LOG_LS << "Allocated own console.\n";
created_wincon_ = true;
} else {
ERR_LS << "Console attachment or allocation failed!\n";
return;
// Wine as of version 4.21 just goes ERROR_ACCESS_DENIED when trying
// to allocate a console for a GUI subsystem application. We can ignore
// this since the user purportedly knows what they're doing and if they
// get radio silence from Wesnoth and no log files they'll realize that
// something went wrong.
WRN_LS << "Cannot attach or allocate a console, continuing anyway (is this Wine?)\n";
}
DBG_LS << "stderr to console\n";