upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2024-09-20 07:51:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Lua API: remove deprecated unit.side and terrain.owner

Browse Source
This commit is contained in:
Charles Dang 2024-09-15 01:43:11 -04:00
parent 78676a27ad
commit 3af690331a
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelog_entries/removed-lua-side-index-getters.md Normal file
View File

@ -0,0 +1,2 @@
### Lua API
* Removed properties `unit.side` and `terrain.owner`. Use `unit.side_number` and `terrain.owner_side` instead.

6
src/formula/callable_objects.cpp
View File

@ -279,9 +279,6 @@ variant unit_callable::get_value(const std::string& key) const
return formula_callable::convert_vector(u_.advances_to()); return formula_callable::convert_vector(u_.advances_to());
} else if(key == "states" || key == "status") { } else if(key == "states" || key == "status") {
return formula_callable::convert_set(u_.get_states()); return formula_callable::convert_set(u_.get_states());
} else if(key == "side") {
deprecated_message("unit.side", DEP_LEVEL::FOR_REMOVAL, version_info("1.17"), "This returns 0 for side 1 etc and should not be used. Use side_number instead.");
return variant(u_.side()-1);
} else if(key == "side_number") { } else if(key == "side_number") {
return variant(u_.side()); return variant(u_.side());
} else if(key == "cost") { } else if(key == "cost") {
@ -631,9 +628,6 @@ variant terrain_callable::get_value(const std::string& key) const
return variant(t_.is_keep()); return variant(t_.is_keep());
} else if(key == "healing") { } else if(key == "healing") {
return variant(t_.gives_healing()); return variant(t_.gives_healing());
} else if(key == "owner") {
deprecated_message("terrain.owner", DEP_LEVEL::FOR_REMOVAL, version_info("1.17"), "This returns 0 for side 1 etc and should not be used. Use owner_side instead.");
return variant(owner_ - 1);
} else if(key == "owner_side") { } else if(key == "owner_side") {
return variant(owner_); return variant(owner_);
} }