From 40959658132c7772a3b77bd1fd4f42f57abbe0c4 Mon Sep 17 00:00:00 2001 From: Nils Kneuper Date: Tue, 27 Apr 2010 10:38:56 +0000 Subject: [PATCH] remove a feature from the addon manager... ...that creates problems on the server atm: no teamcolorize for the icon list till the server is fixed again what should be done: serialize the teamcolorize call, so that the script only starts one instance at a time --- data/tools/addon_manager/html.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/data/tools/addon_manager/html.py b/data/tools/addon_manager/html.py index e748ce32b00..1f5d30a263d 100755 --- a/data/tools/addon_manager/html.py +++ b/data/tools/addon_manager/html.py @@ -91,8 +91,13 @@ Select the add-on you want to install from the list and click "OK". The download sys.stderr.write("Cannot find icon " + icon + "\n") src = root_dir + "images/misc/missing-image.png" imgurl = "icons/missing-image.png" - Popen([os.path.join(am_dir, "../unit_tree/TeamColorizer"), - src, path + "/" + imgurl]) + #the following line results in many instances of TeamColorizer being + #spawned which currently helps killing the server + #TODO: make sure that this is serialized, as in "only one process of + #TeamColorizer running due to the current call of ths script at a + #time" + #Popen([os.path.join(am_dir, "../unit_tree/TeamColorizer"), + # src, path + "/" + imgurl]) type = v("type", "none") size = float(v("size", "0"))