upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-18 21:49:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use empty() method instead of size() for emptiness checks

Browse Source 
Found by cppcheck.
This commit is contained in:
Ignacio R. Morelle 2015-07-06 23:31:05 -03:00
parent ef0eb55f24
commit 413d3528bd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/help/help_impl.cpp
View File

@ -581,7 +581,7 @@ std::vector<topic> generate_faction_topics(const config & era, const bool sort_g
}
}
if (races.size() > 0) {
if (!races.empty()) {
std::set<std::string>::iterator it = races.begin();
text << _("Races: ") << *(it++);
while(it != races.end()) {
@ -590,7 +590,7 @@ std::vector<topic> generate_faction_topics(const config & era, const bool sort_g
text << "\n\n";
}
if (alignments.size() > 0) {
if (!alignments.empty()) {
std::set<std::string>::iterator it = alignments.begin();
text << _("Alignments: ") << *(it++);
while(it != alignments.end()) {
@ -878,7 +878,7 @@ std::vector<topic> generate_unit_topics(const bool sort_generated, const std::st
text << race_description << "\n\n";
}
if (alignments.size() > 0) {
if (!alignments.empty()) {
std::set<std::string>::iterator it = alignments.begin();
text << (alignments.size() > 1 ? _("Alignments: ") : _("Alignment: ")) << *(it++);
while(it != alignments.end()) {