From 413d3528bdf65fbac94dbfc642871450d9acab31 Mon Sep 17 00:00:00 2001 From: "Ignacio R. Morelle" Date: Mon, 6 Jul 2015 23:31:05 -0300 Subject: [PATCH] Use empty() method instead of size() for emptiness checks Found by cppcheck. --- src/help/help_impl.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/help/help_impl.cpp b/src/help/help_impl.cpp index 3450ac43bbf..a3106f8628f 100644 --- a/src/help/help_impl.cpp +++ b/src/help/help_impl.cpp @@ -581,7 +581,7 @@ std::vector generate_faction_topics(const config & era, const bool sort_g } } - if (races.size() > 0) { + if (!races.empty()) { std::set::iterator it = races.begin(); text << _("Races: ") << *(it++); while(it != races.end()) { @@ -590,7 +590,7 @@ std::vector generate_faction_topics(const config & era, const bool sort_g text << "\n\n"; } - if (alignments.size() > 0) { + if (!alignments.empty()) { std::set::iterator it = alignments.begin(); text << _("Alignments: ") << *(it++); while(it != alignments.end()) { @@ -878,7 +878,7 @@ std::vector generate_unit_topics(const bool sort_generated, const std::st text << race_description << "\n\n"; } - if (alignments.size() > 0) { + if (!alignments.empty()) { std::set::iterator it = alignments.begin(); text << (alignments.size() > 1 ? _("Alignments: ") : _("Alignment: ")) << *(it++); while(it != alignments.end()) {