upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-04-30 23:12:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove a temporary used only once.

Browse Source 
Instead use the return value of the function used to initialise the
temporary.
This commit is contained in:
Mark de Wever 2013-06-08 12:02:31 +02:00
parent 2e8e81bc34
commit 93eaedde07
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/menu_events.cpp
View File

@ -2290,11 +2290,10 @@ void chat_command_handler::do_ignore()
const std::map<std::string, std::string>& tmp = preferences::get_acquaintances_nice("ignore");
print(_("ignores list"), tmp.empty() ? _("(empty)") : utils::join_map(tmp, ")\n", " (") + ")");
} else {
std::string reason = get_data(2);
utils::string_map symbols;
symbols["nick"] = get_arg(1);
if (preferences::add_ignore(get_arg(1), reason)) {
if (preferences::add_ignore(get_arg(1), get_data(2))) {
print(_("ignores list"), VGETTEXT("Added to ignore list: $nick", symbols));
chat_handler_.user_relation_changed(get_arg(1));
} else {
@ -2309,11 +2308,10 @@ void chat_command_handler::do_friend()
const std::map<std::string, std::string>& tmp = preferences::get_acquaintances_nice("friend");
print(_("friends list"), tmp.empty() ? _("(empty)") : utils::join_map(tmp, ")\n", " (") + ")");
} else {
std::string notes = get_data(2);
utils::string_map symbols;
symbols["nick"] = get_arg(1);
if (preferences::add_friend(get_arg(1), notes)) {
if (preferences::add_friend(get_arg(1), get_data(2))) {
print(_("friends list"), VGETTEXT("Added to friends list: $nick", symbols));
chat_handler_.user_relation_changed(get_arg(1));
} else {