From b73d1ac9b8bfd32b27ede8e604112b895d3f7878 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sat, 17 Oct 2009 05:37:53 +0000 Subject: [PATCH] Pass parameter by const ref instead of const value. Issue found by cppcheck. --- src/ai/testing/ca_testing_move_to_targets.cpp | 2 +- src/ai/testing/ca_testing_move_to_targets.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ai/testing/ca_testing_move_to_targets.cpp b/src/ai/testing/ca_testing_move_to_targets.cpp index ac6c16f6f90..247832e7c35 100644 --- a/src/ai/testing/ca_testing_move_to_targets.cpp +++ b/src/ai/testing/ca_testing_move_to_targets.cpp @@ -853,7 +853,7 @@ double testing_move_to_targets_phase::rate_group(const std::set& g -bool testing_move_to_targets_phase::should_retreat(const map_location& loc, const unit_map::const_iterator un, +bool testing_move_to_targets_phase::should_retreat(const map_location& loc, const unit_map::const_iterator& un, const move_map& srcdst, const move_map& dstsrc, const move_map& enemy_dstsrc, double caution) { diff --git a/src/ai/testing/ca_testing_move_to_targets.hpp b/src/ai/testing/ca_testing_move_to_targets.hpp index 0d752e35dbc..f31c165e561 100644 --- a/src/ai/testing/ca_testing_move_to_targets.hpp +++ b/src/ai/testing/ca_testing_move_to_targets.hpp @@ -74,7 +74,7 @@ protected: const move_map& dstsrc, const move_map& enemy_dstsrc, const plain_route& rt); - bool should_retreat(const map_location& loc, const unit_map::const_iterator un, + bool should_retreat(const map_location& loc, const unit_map::const_iterator& un, const move_map& srcdst, const move_map& dstsrc, const move_map& enemy_dstsrc, double caution); };