upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-10 21:56:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix assertion failure and OOS when attacking with DSU active

Browse Source 
undo_stack.clear() shouldn't be called from outside the synced contect
since it might fire sigted events and similar.

The attack handle in synced_commands.cpp already calls clear() so its
enought to just rmeove it here.
This commit is contained in:
gfgtdf 2016-02-15 17:58:40 +01:00
parent 6e0f8ed6d7
commit ba154d07b9
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mouse_events.cpp
View File

@ -1010,9 +1010,6 @@ void mouse_handler::attack_enemy_(const map_location& att_loc
const map_location attacker_loc = att_loc; const map_location attacker_loc = att_loc;
const map_location defender_loc = def_loc; const map_location defender_loc = def_loc;
//may fire event and modify things
pc_.get_undo_stack().clear();
unit_map::iterator attacker = find_unit(attacker_loc); unit_map::iterator attacker = find_unit(attacker_loc);
if(!attacker if(!attacker
|| attacker->side() != side_num_ || attacker->side() != side_num_