upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-04-24 18:48:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Used a deque instead of a vector for active event handlers

Browse Source 
Since events can be added and removed constantly, this should be more performance-friendly than
a vector since it avoids reallocations. Though, since this container only holds shared_ptrs instead
of the objects themselves, it probably doesn't make that much difference right now, but I might
switch to object-direct storage in the future. Not sure.
This commit is contained in:
Charles Dang 2018-01-18 13:29:27 +11:00
parent 7aa39dc451
commit ba8aa80af8
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/game_events/manager_impl.hpp
View File

@ -17,6 +17,7 @@
#include "game_events/fwd.hpp"
#include "config.hpp"
#include <deque>
#include <unordered_map>
namespace game_events
@ -25,7 +26,7 @@ namespace game_events
class event_handlers
{
private:
using handler_vec_t = std::vector<handler_ptr>;
using handler_queue_t = std::deque<handler_ptr>;
using map_t = std::unordered_map<std::string, handler_list>;
using id_map_t = std::unordered_map<std::string, weak_handler_ptr>;
@ -34,7 +35,7 @@ private:
* This is the only container that actually 'owns' any events in the form of shared_ptrs. The other
* three storage methods own weak_ptrs.
*/
handler_vec_t active_;
handler_queue_t active_;
/** Active event handlers with fixed event names, organized by event name. */
map_t by_name_;
@ -66,12 +67,12 @@ public:
}
/** Read-only access to the active event handlers. Essentially gives all events. */
const handler_vec_t& get_active() const
const handler_queue_t& get_active() const
{
return active_;
}
handler_vec_t& get_active()
handler_queue_t& get_active()
{
return active_;
}