upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-11 01:24:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

sprintf is bad and shouldn't be used, use snprintf instead

Browse Source
This commit is contained in:
Mark de Wever 2007-05-09 19:05:25 +00:00
parent a590427c31
commit c3f9d55a10
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ai_dfool.cpp
View File

@ -16,7 +16,7 @@ namespace dfool {
config side_filter; config side_filter;
char buf[80]; char buf[80];
sprintf(buf,"%d",team_num); snprintf(buf, sizeof(buf), "%d", team_num);
side_filter["side"]=buf; side_filter["side"]=buf;
LOG_STREAM(info, ai)<<"dfool sees:"<<std::endl; LOG_STREAM(info, ai)<<"dfool sees:"<<std::endl;

10
src/unit.cpp
View File

@ -272,9 +272,9 @@ unit::unit(const game_data* gamedata, unit_map* unitmap, const gamemap* map,
if(underlying_description_.empty()){ if(underlying_description_.empty()){
char buf[80]; char buf[80];
if(!custom_unit_description_.empty()){ if(!custom_unit_description_.empty()){
sprintf(buf,"%s-%d-%s",type()->id().c_str(),(SDL_GetTicks()), custom_unit_description_.c_str()); snprintf(buf, sizeof(buf), "%s-%d-%s",type()->id().c_str(),(SDL_GetTicks()), custom_unit_description_.c_str());
}else{ }else{
sprintf(buf,"%s-%d",type()->id().c_str(),(SDL_GetTicks())); snprintf(buf, sizeof(buf), "%s-%d",type()->id().c_str(),(SDL_GetTicks()));
} }
underlying_description_ = buf; underlying_description_ = buf;
} }
@ -320,9 +320,9 @@ unit::unit(const unit_type* t, int side, bool use_traits, bool dummy_unit, unit_
if(underlying_description_.empty()){ if(underlying_description_.empty()){
char buf[80]; char buf[80];
if(!custom_unit_description_.empty()){ if(!custom_unit_description_.empty()){
sprintf(buf,"%s-%d-%s",type()->id().c_str(),(SDL_GetTicks()), custom_unit_description_.c_str()); snprintf(buf, sizeof(buf), "%s-%d-%s",type()->id().c_str(),(SDL_GetTicks()), custom_unit_description_.c_str());
}else{ }else{
sprintf(buf,"%s-%d",type()->id().c_str(),(SDL_GetTicks())); snprintf(buf, sizeof(buf), "%s-%d",type()->id().c_str(),(SDL_GetTicks()));
} }
underlying_description_ = buf; underlying_description_ = buf;
} }
@ -949,7 +949,7 @@ void unit::read(const config& cfg)
underlying_description_ = cfg["description"]; underlying_description_ = cfg["description"];
if(underlying_description_.empty()){ if(underlying_description_.empty()){
char buf[80]; char buf[80];
sprintf(buf,"%s-%d",cfg["type"].c_str(),(SDL_GetTicks()%1000000)); snprintf(buf, sizeof(buf), "%s-%d",cfg["type"].c_str(),(SDL_GetTicks()%1000000));
underlying_description_ = buf; underlying_description_ = buf;
} }
if(description_.empty()) { if(description_.empty()) {