upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-04-28 15:10:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix #7821: all cases of the calculation should be cached

Browse Source 
in the previous logic some cases return from the function and others
would set a return variable that would be set later.

this commit, changes all the cases into all assignment.
This commit is contained in:
Goncalo Gomes 2023-09-13 10:35:01 +01:00 committed by Gunter Labes
parent e0b130434a
commit cab2a1b8f1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ai/default/recruitment.cpp
View File

@ -933,11 +933,11 @@ double recruitment::compare_unit_types(const std::string& a, const std::string&
double value_of_b = damage_to_a / (a_max_hp * b_cost);
if (value_of_a > value_of_b) {
return value_of_a / value_of_b;
retval = value_of_a / value_of_b;
} else if (value_of_a < value_of_b) {
return -value_of_b / value_of_a;
retval = -value_of_b / value_of_a;
} else {
return 0.;
retval = 0.;
}
}