upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-07 19:43:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #2067: Scrolling position in Lua console is reset constantly

Browse Source 
The problem is that a line that's too wide to fit into the window
invalidates the layout of the entire window, and the window will lay itself
out the next time it will be drawn, after the Lua console code has scrolled
it to bottom.

The easiest fix is to simply defer scrolling to bottom until the window has
been drawn (and thus laid out) next time.
This commit is contained in:
Jyrki Vesterinen 2017-12-04 20:53:12 +02:00
parent 73a3e3cc63
commit d00ed24d14
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/gui/dialogs/lua_interpreter.cpp
View File

@ -80,12 +80,14 @@ REGISTER_DIALOG(lua_interpreter)
class lua_interpreter::view {
private:
scroll_label* msg_label; //the view is extremely simple, it's pretty much just this one widget that gets updated
window* window_;
public:
view() : msg_label(nullptr) {}
view() : msg_label(nullptr), window_(nullptr) {}
/** Bind the scroll label widget to my pointer, and configure */
void bind(window& window) {
window_ = &window;
msg_label = find_widget<scroll_label>(&window, "msg", false, true);
msg_label->set_use_markup(true);
msg_label->set_vertical_scrollbar_mode(scrollbar_container::ALWAYS_VISIBLE);
@ -98,7 +100,10 @@ public:
assert(msg_label);
msg_label->set_label(str);
msg_label->scroll_vertical_scrollbar(scrollbar_base::END);
window_->set_callback_next_draw([this]()
{
msg_label->scroll_vertical_scrollbar(scrollbar_base::END);
});
}
void pg_up()