upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-04-17 23:24:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

units_dialog: move item erase from filter (#9839)

Browse Source 
moved before `selected_index_` gets changed to -1 due to
`list_item_selected()`
This commit is contained in:
Subhraman Sarkar 2025-02-04 16:34:51 +05:30
parent 3d0785305a
commit df3b48f4d4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/gui/dialogs/units_dialog.cpp
View File

@ -273,12 +273,13 @@ void units_dialog::dismiss_unit(std::vector<unit_const_ptr>& unit_list, const te
unit_list.erase(unit_list.begin() + selected_index_);
// Remove the entry from the filter list
filter_options_.erase(filter_options_.begin() + selected_index_);
// Remove the entry from the dialog list
list.remove_row(selected_index_);
list_item_clicked();
// Remove the entry from the filter list
filter_options_.erase(filter_options_.begin() + selected_index_);
assert(filter_options_.size() == list.get_item_count());
LOG_DP << "Dismissing a unit, side = " << u.side() << ", id = '" << u.id() << "'";