upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-04-24 03:39:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate using [set_specials] without specifying mode=

Browse Source 
This will show a warning for bugs similar to the UtBS one that
was fixed in 74ad400900eb5264b0485e9f84b90c968c1aba77.
This commit is contained in:
Steve Cotton 2020-02-10 13:29:13 +01:00 committed by gfgtdf
parent be39b7e76c
commit e053566a15
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/units/attack_type.cpp
View File

@ -326,12 +326,17 @@ bool attack_type::apply_modification(const config& cfg)
specials_ = new_specials;
}
if (set_specials) {
if(set_specials) {
const std::string &mode = set_specials["mode"];
if (mode != "append") {
if(mode.empty()){
deprecated_message("[set_specials]mode=<unset>", DEP_LEVEL::INDEFINITE, "",
"The mode defaults to 'replace', but should often be 'append' instead. The default may change in a future version, or the attribute may become mandatory.");
// fall through to mode != "append"
}
if(mode != "append") {
specials_.clear();
}
for (const config::any_child &value : set_specials.all_children_range()) {
for(const config::any_child &value : set_specials.all_children_range()) {
specials_.add_child(value.key, value.cfg);
}
}