upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-04-25 18:43:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't clone surface too early

Browse Source
This commit is contained in:
Charles Dang 2024-08-21 01:09:39 -04:00
parent 365fe71e2c
commit e08fcd1061
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/picture.cpp
View File

@ -803,7 +803,7 @@ bool is_empty_hex(const locator& i_locator)
return *cached_value;
}
surface surf = get_surface(i_locator, HEXED).clone();
surface surf = get_surface(i_locator, HEXED);
// Empty state should be cached during surface fetch. Let's check again
if(const bool* cached_value = is_empty_hex_.locate_in_cache(i_locator)) {
@ -811,6 +811,7 @@ bool is_empty_hex(const locator& i_locator)
}
// Should never reach this point, but let's manually do it anyway.
surf = surf.clone();
bool is_empty = false;
mask_surface(surf, get_hexmask(), &is_empty);
is_empty_hex_.add_to_cache(i_locator, is_empty);