upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-04-24 02:32:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump min and default game window size

Browse Source 
Hopefully, we'll be able to implement better support for layouts that don't relay on pixel canvas sizes, but for now, this solves two important issues:

Using 1280x720 as the default window size means 3x auto pixel scaling for 4k fullscreen, which looks utterly horrendous and unusable. 2x is the practical limit of usability without going so far in the opposite direction as to actually reduce the available space.

Bumping the min window size also resolves #9898 and saves us from having to deal with layouts on unusably small windows.

As a side note, we should not be thinking in terms of pixel size anymore. I'm hoping SDL3 can give us better control over our HDPI support (which is much improved from before), but the fact remains that our current pixel scaling implementation is, essentially, a method to scale up the canvas if your resolution is grater than 1080p. It does nothing for size calculations, and it does nothing if you actually set a window size smaller than 1080p even on a 4k monitor.

So, for now, imperfect solution while we wait for SDL3, but solves the immediate issues with scaling and small window sizes.
This commit is contained in:
Charles Dang 2025-02-15 15:41:49 -05:00
parent 3b262d6f7b
commit ea62841a81
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.md
View File

@ -17,6 +17,7 @@
* new secondary melee attack: 25-2 scimitar melee blade marksman
### User interface
* A new "Customize Reach Map (Unit Movement UI)" option has been added under the advanced settings category. It provides highlight color, enemy highlight color, border opacity and tint opacity customization options for the reach map UI.
* The game will now default to 1920x1080 with a minimum of 1280x720
### WML Engine
* [unit] no longer accepts hp_bar_scaling and xp_bar_scaling keys
### Miscellaneous and Bug Fixes

8
src/preferences/preferences.hpp
View File

@ -33,11 +33,11 @@ class game_board;
namespace pref_constants
{
const int min_window_width = 800;
const int min_window_height = 540;
const int min_window_width = 1280;
const int min_window_height = 720;
const int def_window_width = 1280;
const int def_window_height = 720;
const int def_window_width = 1920;
const int def_window_height = 1080;
const int max_window_width = 1920;
const int max_window_height = 1080;