upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-13 17:42:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some useless code when moving a unit (invalidations and draw()):

Browse Source 
- no need to invalidate adjacent hexes after each step, already done
  when redrawing units with offset and walking

- the last "else" had no effect

- use set_route(NULL) to clear the path, so invalidate it only if present
This commit is contained in:
Ali El Gariani 2007-06-05 14:01:58 +00:00
parent 1bb970a8c6
commit ee73fbe795
1 changed files with 3 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/unit_display.cpp
View File

@ -148,30 +148,15 @@ void move_unit( const gamemap& map, const std::vector<gamemap::location>& path,
} else {
move_unit_between(map,path[i],path[i+1],temp_unit);
}
previous_visible = true;
} else if(previous_visible) {
gamemap::location arr[6];
disp->invalidate(path[i]);
get_adjacent_tiles(path[i], arr);
for (unsigned int i = 0; i < 6; i++) {
disp->invalidate(arr[i]);
}
disp->draw();
previous_visible = false;
} else {
previous_visible = false;
}
}
disp->remove_temporary_unit();
u.set_facing(path[path.size()-2].get_relative_dir(path[path.size()-1]));
u.set_standing(*disp,path[path.size()-1]);
//make sure the entire path is cleaned properly
for(std::vector<gamemap::location>::const_iterator it = path.begin(); it != path.end(); ++it) {
disp->remove_footstep(*it);
disp->invalidate(*it);
}
//clean the footsteps path, its hexes will be invalidated if needed
disp->set_route(NULL);
u.set_hidden(was_hidden);
disp->invalidate_unit();
}