upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-16 18:31:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure all members are initialized in the constructor.

Browse Source
This commit is contained in:
Mark de Wever 2007-12-03 19:58:12 +00:00
parent 68491ba17d
commit fd65d1d319
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/reports.hpp
View File

@ -42,6 +42,16 @@ namespace reports {
const std::string& report_name(TYPE type);
struct element {
private:
//! Shouldn't be used so only declared.
element();
public:
explicit element(const std::string& text) :
image(),
text(text),
tooltip()
{}
// Invariant: either text or image should be empty
// It would be okay to create a class for this, but it's a pretty simple
// invariant so I left it like the original report class.
@ -49,9 +59,6 @@ namespace reports {
std::string text;
std::string tooltip;
element() {}
explicit element(const std::string& text) : text(text) {}
element(const std::string& text, const std::string& image, const std::string& tooltip) :
image(image), text(text), tooltip(tooltip) {}