The main reason for reverting are:
The stuff has hampered my development for almost a month now, including
forcing me to delay things I need to/want to work on.
The recruit dialog looks very ugly on 1024x768 since it doesn't fit entirely
on the screen. It's still usable, but lowering the height of the main window
makes the dialog unusable.
The code includes several new wml errors:
"Invalid WML found: Window builder: parsing resolution tip with empty 'id'
field. Will become mandatory in 1.9.7. (4)"
The unit tests are broken, and instead of being fixed properly their
code is being `fixed' by disabling tests. 2011-03-05T20:39:56Z!fabianmueller5@gmx.de indicates it
should fix the unit tests, but it doesn't so the code seems
untested. Which means I still can't use the tests for other code I
want to commit.
In 2011-03-05T09:12:02Z!fabianmueller5@gmx.de fendrin commits not working code with the goal to
force me to help him, which I consider bad practice, show the code in
a pastebin if you want help. I want to work on things when _I_ choose
to, and not being coerced to by committing bad code.
Commit 2011-03-05T12:04:13Z!fabianmueller5@gmx.de throws private _GUI* macros in a global header,
which might break other code in unexpected ways. The file modified
even contains the documentation regarding how to use GUI* and _GUI*
macros. And another remark that I should look at fixing the issue.
So I had enough of this stuff; it's incomplete, buggy and hampers the work
of at least one other developer for several weeks now.
Reverts fendrin's commits:
2011-02-11T19:01:16Z!fabianmueller5@gmx.de
2011-02-12T06:25:47Z!fabianmueller5@gmx.de
2011-02-12T16:43:20Z!fabianmueller5@gmx.de
2011-02-12T17:37:40Z!fabianmueller5@gmx.de
2011-02-12T18:36:30Z!fabianmueller5@gmx.de
2011-02-12T19:59:34Z!fabianmueller5@gmx.de
2011-02-12T20:47:43Z!fabianmueller5@gmx.de
2011-02-12T21:41:35Z!fabianmueller5@gmx.de
2011-02-12T22:35:15Z!fabianmueller5@gmx.de
2011-02-14T19:24:40Z!fabianmueller5@gmx.de
2011-02-14T20:55:55Z!fabianmueller5@gmx.de,
2011-03-02T18:59:59Z!fabianmueller5@gmx.de
2011-03-03T13:34:48Z!fabianmueller5@gmx.de
2011-03-03T13:56:10Z!fabianmueller5@gmx.de
2011-03-03T17:32:49Z!fabianmueller5@gmx.de
2011-03-04T00:52:26Z!fabianmueller5@gmx.de
2011-03-04T11:27:39Z!fabianmueller5@gmx.de
2011-03-04T11:28:48Z!fabianmueller5@gmx.de
2011-03-05T09:12:02Z!fabianmueller5@gmx.de
2011-03-05T11:16:09Z!fabianmueller5@gmx.de
2011-03-05T11:19:37Z!fabianmueller5@gmx.de
2011-03-05T11:21:19Z!fabianmueller5@gmx.de
2011-03-05T11:32:25Z!fabianmueller5@gmx.de
2011-03-05T11:47:30Z!fabianmueller5@gmx.de
2011-03-05T12:00:39Z!fabianmueller5@gmx.de
2011-03-05T12:01:22Z!fabianmueller5@gmx.de
2011-03-05T12:02:03Z!fabianmueller5@gmx.de
2011-03-05T12:02:46Z!fabianmueller5@gmx.de
2011-03-05T12:04:13Z!fabianmueller5@gmx.de
2011-03-05T12:05:02Z!fabianmueller5@gmx.de
2011-03-05T12:20:25Z!fabianmueller5@gmx.de
2011-03-05T12:24:39Z!fabianmueller5@gmx.de
2011-03-05T13:56:43Z!fabianmueller5@gmx.de,
2011-03-05T16:32:38Z!fabianmueller5@gmx.de
2011-03-05T16:34:34Z!fabianmueller5@gmx.de
2011-03-05T16:35:17Z!fabianmueller5@gmx.de
2011-03-05T20:39:56Z!fabianmueller5@gmx.de
2011-03-05T22:17:03Z!fabianmueller5@gmx.de
2011-03-05T22:29:29Z!fabianmueller5@gmx.de.
Also reverts a build system change that is no longer needed:
2011-03-05T16:35:04Z!anonymissimus@arcor.de
...testing_ai_default::default_move_to_targets_phase into
testing_ai_default::testing_move_to_targets_phase - set up everything
for experiments on ai movement and targeting phase
