78908 Commits

Author SHA1 Message Date
Celtic Minstrel
0839feed00 Schema: Add missing accuracy/parry keys to [attack] 2021-04-10 18:18:48 -04:00
Pentarctagon
cd26e800fa When checking [variable] comparison attributes, return after checking the first one.
The current implementation technically allows for there to be multiple comparison attributes present and it will return false if any of them are false or return true if all of them are true. This changes the implementation to only check the first comparison attribute found and return true or false based on that check, which is how the [variable] tag is documented as working on the wiki.
2021-04-10 17:01:04 -05:00
mattsc
fabaa5a28e
Merge pull request #5693 from mattsc/attack_comparison_poison
Fix better_attack evaluation for poison attacks
2021-04-10 09:26:44 -07:00
Steve Cotton
17cbc7c03e Fixup 7cbc6c9d5d and 5bb0576e17 2021-04-10 14:22:40 +02:00
Nils Kneuper
ebac0830cb updated Chinese (Traditional) translation 2021-04-10 11:26:34 +02:00
Nils Kneuper
01bebdd51d updated Czech translation 2021-04-10 11:19:37 +02:00
Nils Kneuper
7a348ddfcc updated Italian translation 2021-04-10 11:17:54 +02:00
Celtic Minstrel
5bb0576e17 Add some event filter tests 2021-04-09 23:09:47 -04:00
Celtic Minstrel
7cbc6c9d5d Add unit tests for auto-scoped variables in events 2021-04-09 23:09:47 -04:00
Celtic Minstrel
aa8e171816 Add more unit tests for nested event handlers and a few other things 2021-04-09 23:09:47 -04:00
Iris Morelle
af974405c3 gui2/game_version: Clean up includes 2021-04-09 22:15:22 -04:00
Iris Morelle
f23ef62282 font: Cleanup link formatting logic
Let's internally handle this mess in terms of tokens instead of
delimiter positions.

This alters the code so we don't add and substract ones (1) all over the
place. It also simplifies the final std::string_view::substr() call so
we don't need to count the remainder's length at all.

And more importantly, this makes the case where no delimiters had been
previously found trivial instead of causing it to break and result in no
text being output at all. We also don't start with a size_t value of -1
(actually a very large unsigned value).

Closes #5625.
2021-04-09 21:04:45 -04:00
mattsc
1892ba32ed Fix better_attack evaluation for poison attacks
Poison is added to the attack damage when comparing attacks by the same unit with different weapons, but it should only be counted as a bonus if the enemy survives, otherwise it serves no purpose.
2021-04-09 16:35:16 -07:00
Pentarctagon
a2c795bfd7
Remove verbose flag from WML unit tests. 2021-04-08 22:03:32 -05:00
Iris Morelle
e3432738af Update changelog
[ci skip]
2021-04-08 18:10:51 -04:00
Iris Morelle
8a2faf24e3 wmlunits: Units may have movement cost == max mp and be able to move
This applies to the Walking Corpse in particular, which has 4 MP and 4
movement cost to enter shallow water. In practice this means that it can
move into shallow water only if it's not slowed and hasn't spent any
movement points this turn, and then it cannot move any further until the
next turn.

Closes #5689.
2021-04-08 18:05:54 -04:00
Iris Morelle
9f7d6b104b Test DOS device names in addons/validation 2021-04-08 17:44:14 -04:00
Iris Morelle
4ed1a9c784 Check for illegal filenames after the Save Game dialog is displayed
Closes #5679.
2021-04-08 17:12:54 -04:00
Iris Morelle
e90067936d fs: Add allow_whitespace parameter to is_legal_user_file_name()
This is supposed to be false for the add-ons server, true (default) for
saved games.
2021-04-08 17:12:54 -04:00
Iris Morelle
7f71a6e849 fs: Move addon filename validation logic to the filesystem namespace
This will enable us to use this in other places where filenames are
constructed partially or entirely from user input.
2021-04-08 17:12:54 -04:00
Celtic Minstrel
1273aba5d8 run_wml_tests: Drastically reduce output when run without -v
It now ONLY outputs failures and the summary; tests that passed are not even mentioned
2021-04-07 20:41:37 -04:00
Pentarctagon
c1fad387c1
Add the high contrast icons to cmake for installation.
Fixes #5685
2021-04-07 17:10:45 -05:00
Pentarctagon
01695acfe0 Log an error if a [variable] is found that's not comparing any values. 2021-04-07 17:08:45 -05:00
newfrenchy83
f70039fe26 update codeblock projectfiles 2021-04-07 11:47:00 -05:00
Charles Dang
0575bde289
Merge pull request #5677 from knyghtmare/knyghtmare-sand-scuttler-variation-name-fix
Fix for Giant Scorpion having an empty variation name.
2021-04-06 12:01:57 -04:00
Charles Dang
feda47baba
Merge pull request #5672 from stevecotton/align_debug_clock
Make the debug clock look right
2021-04-06 11:57:01 -04:00
Charles Dang
b1e533c8bc
Merge pull request #5678 from stevecotton/build_debug_window_layout
Fix building with ENABLE_DEBUG_WINDOW_LAYOUT
2021-04-06 11:18:21 -04:00
Steve Cotton
075e08faff Fix building with ENABLE_DEBUG_WINDOW_LAYOUT
It turned out to not be the tool that I need, so please don't
ask me for any help using it.
2021-04-06 15:54:09 +02:00
Tahsin Jahin Khalid
d52c5a8880 Update Giant_Scorpion.cfg 2021-04-06 19:15:10 +06:00
Tahsin Jahin Khalid
8cf20f263b village support +1 for 2 player mode (#5)
this sort of makes Dark Forecast passable for 2 player mode. Initially, it was only passable if it was one-player-mode as one player could have 11 villages active and could get a good army built prior to the final wave.
2 player suffered from lack of resources to replace losses and would be unwinnable in some cases.
Only 2 cases where it was won in 2 player mode was when the players were of exceptionally high skill level but average skill-levelled players have yet to even win.
2021-04-05 14:02:26 -05:00
Celtic Minstrel
f9500f9b0e Add unit tests for utils::square_parenthetical_split 2021-04-05 13:35:52 -04:00
Celtic Minstrel
01cc36dabb Add unit tests for utils::parenthetical_split 2021-04-05 13:35:52 -04:00
Celtic Minstrel
730afb3d4b Add some unit tests for utils::split and utils::map_split 2021-04-05 13:35:52 -04:00
Celtic Minstrel
74afe17ddf Add the new GUI2 dialog to the unit tests in the Xcode project 2021-04-05 13:35:52 -04:00
Celtic Minstrel
7860b2845b Add some missing test files to the Xcode project 2021-04-05 13:35:52 -04:00
Steve Cotton
489d364cb6 Make the debug clock look right
This is the only widget in mainline using GUI2's [draw][circle] tag. I'm
currently working on a change to the C++ text_shape class, and want to
be able to regression-test the placement of [circle]s after that change.

I'd be okay with deprecating both [circle] and [round_rectangle] as neither
seems to be used elsewhere, but this close to feature-freeze I'd prefer to keep
them in 1.16 rather than suggest removing them now.

To see the widget, start the game with `wesnoth --clock`, and then click the
button underneath "Quit" on the main menu.
2021-04-05 12:59:10 +02:00
doofus-01
3da068801b
terrain-graphics - remove hard cut on convex walls of human castle ruins, to blend with sunken ruins (#5667) 2021-04-04 12:08:48 -07:00
Steve Cotton
de3e798e72 Update the animals Micro-AI demo with boars and piglets
This adjusts to the change in e7b5996e988747c2b590852b4b461abe48857526.

The micro ai itself is unchanged, it's still controlled by `tusker_type` and
`tusklet_type`, it simply needed the new unit ids to be used in this scenario.
2021-04-04 20:23:46 +02:00
Celtic Minstrel
942743eb78
run_wml_tests: Fix indentation 2021-04-04 10:44:26 -04:00
Celtic Minstrel
be4b10a611 Update Xcode project
In addition to the new source file, this adds a number of header files that had been missed in previous updates.
2021-04-04 03:44:10 -04:00
Pentarctagon
139370b0a8
Remove comments so doxygen will use the parent class's comment. 2021-04-04 02:37:51 -05:00
Steve Cotton
6579f073c1 pango_text: remove unused force options and single-character insertion
The single-character insertion seems unlikely to be used in future. While
pango_text isn't a singleton, a few shared instances are created and then used
in a singleton-like way, with each caller assuming that it received it in an
unknown state and always calling set_text(), set_font_size(), set_font_style(),
etc.
2021-04-04 08:47:32 +02:00
Pentarctagon
38e7afb07f
Update changelog. 2021-04-04 01:32:01 -05:00
Pentarctagon
6b97a76109 Add a prompt to allow entering an add-on's password at upload time.
This is an alternative to needing to store the plaintext password in the _server.pbl.
2021-04-04 01:28:23 -05:00
Celtic Minstrel
5fc4b235a9 WFL: Fix carryover bonus being represented as an int 2021-04-04 00:58:57 -04:00
Celtic Minstrel
a755788392 run_wml_tests: Skip tests that expect strict validation failure if log-strict is disabled 2021-04-04 00:58:48 -04:00
Celtic Minstrel
099414ed1e run_wml_tests: Don't append to the provided path if it's not a directory
This allows passing an explicit path on Mac (instead of using the automatic -p xcode option), since the binary is not named "wesnoth" on that platform.
2021-04-04 00:58:42 -04:00
doofus-01
77f8112032
Update changelog.md 2021-04-03 21:18:31 -07:00
doofus-01
e7b5996e98
remove reference to tusker, replace with boar or piglet (#5662)
* remove reference to tusker, replace with boar or piglet
2021-04-03 21:15:24 -07:00
doofus-01
31bc471d39
Update changelog.md 2021-04-03 16:39:55 -07:00