84236 Commits

Author SHA1 Message Date
Gothyoba
198b798e49
Make sure ELvish Race Description doesn't contradict WoF (#9505) 2024-10-27 13:57:27 +06:00
Charles Dang
61480df8eb Events: use native SDL handling for double click events
GUI2 still does its own handling with double clicks. This doesn't touch that. The default SDL handling is either 500ms (unchanged) or queried from the OS on Windows (an improvement). The click radius defaults to 32, which honestly seems like an acceptable adjustment.
2024-10-26 23:47:10 -04:00
Charles Dang
71dbaab868 Events/Pump Info: remove unused resize_dimensions member
This was set and never used. It was, at some point, I believe, but evidently got refactored out over the years.
2024-10-26 23:47:10 -04:00
Charles Dang
1ba3be778b Events: split off rate counting from pump_info::ticks
This interface was extremely confusing. pum_info is designed to set `ticks_` only once. This can lead to a situation (exemplified by the music code) where if ticks() is called multiple times in a row, the subsequent times with a counter, that counter would never be incremented since the condition that tests them short circuits on the is-ticks-not-set check.

Also, giving ticks() multiple side effects was very confusing.
2024-10-26 23:47:10 -04:00
SomeName42
44bb36d411 Sound source full_range and fade_range are now allowed to be 0. When fade_range=0 division by zero prevented. 2024-10-26 17:13:18 -04:00
Wedge009
b5e500cfda Correct string concatenation. 2024-10-26 11:11:53 -04:00
Wedge009
3baf3fefe8 Update mark-up as per PR feedback. 2024-10-26 11:11:53 -04:00
Wedge009
c26d45d56e Remove reference to obsolete and Windows-specific Notepad.
[ci skip]
2024-10-26 11:11:53 -04:00
Wedge009
fb2045120b Avoid including mark-up in Help translated text. 2024-10-26 11:11:53 -04:00
Wedge009
e01fbb6b02 Correct one more non-typographic apostrophe...
[ci skip]
2024-10-26 11:11:53 -04:00
Wedge009
b3ed22d697 Editor Help: text corrections.
[ci skip]
2024-10-26 11:11:53 -04:00
Subhraman Sarkar
dc78046d0f rich label: support text_font_size resolution key
also, mouse handler will only be registered if the rich_label is link aware and has a registered link handler.
2024-10-26 20:11:37 +05:30
Nils Kneuper
0954c2445e updated Hungarian translation 2024-10-26 14:21:10 +02:00
Nils Kneuper
7f9879fc08 updated British English translation 2024-10-26 14:20:07 +02:00
Nils Kneuper
deea9ad009 updated Arabic translation 2024-10-26 13:50:40 +02:00
Charles Dang
b4d70c4224 Bump vcpkg baseline 2024-10-25 17:01:27 -04:00
MechanicalDragon963
70df290584
Tweak some Elvish units stats (#9440)
* Elvish Scout: XP 42 -> 32;
* Elvish Rider: XP 75 -> 60; HP 49 -> 46; bow damage 11 -> 9; cost 28 -> 27;
* Elvish Outrider: MP 11 -> 10; HP 60 -> 57; bow damage 11 -> 9; sword damage 8 -> 7; cost 58 -> 50;
* Elvish Avenger: HP 59 -> 55; cost 60 -> 55.
2024-10-25 15:08:48 -05:00
Charles Dang
dfa4d7dd35 Remove chars_equals_insensitive and chars_less_insensitive
These aren't used anymore as of #9332 (save one place, which has been inlined here), and they're not good to rely on, since they don't handle utf8 properly.
2024-10-25 14:53:17 -04:00
Charles Dang
ebf825668d Add utils::erase to complement erase_if
Both can be replaced with their standard library counterparts once we use C++20 by default.
2024-10-25 13:20:59 -04:00
Charles Dang
cb4d8a8dff Deploy utils::erase_if 2024-10-25 04:03:23 -04:00
Charles Dang
84c414c58b Make use of sdl::get_mouse_location() when possible 2024-10-25 02:41:59 -04:00
Charles Dang
0e8edd12e4 Remove display::get_location_x|y 2024-10-25 02:41:59 -04:00
Charles Dang
9f806362ae Clean up display::hexes_under_rect 2024-10-25 02:41:59 -04:00
Charles Dang
ec7679d07f Rename rect::pos() to origin() 2024-10-25 02:41:59 -04:00
Charles Dang
5ab73a51fd Display: use point math for viewport position 2024-10-25 02:41:59 -04:00
Wedge009
d338c90381 Save game: text correction
[ci skip]
2024-10-24 22:03:44 -04:00
Subhraman Sarkar
c284a080e3 campaign selection: opening add-ons manager entry 2024-10-22 19:59:55 -04:00
white-haired-uncle
e6d5100924 multi_page::remove_page - account for index when limiting number of pages to remove 2024-10-21 18:57:41 -04:00
pentarctagon
a34e4a345a remove empty single space 2024-10-21 12:15:06 -05:00
pentarctagon
fd426b5b9b 1.19.5+dev 2024-10-21 12:13:11 -05:00
pentarctagon
383ba03664 1.19.5 1.19.5 2024-10-21 12:10:10 -05:00
pentarctagon
7047c8f581 changelog_entries 2024-10-21 12:02:37 -05:00
pentarctagon
019da2f54c pot-update and regenerate doc files 2024-10-21 11:36:51 -05:00
Gothyoba
d7c9716265 Move EI Music to Core 2024-10-20 14:50:46 -05:00
SomeName42
a5e17f770d The cause of the crash was that the active_menu_ variable was set to UNIT_FACING after the unit facing setting is finished. When clicking the menu it was looking for a unit because of the value of the active_menu_ variable and on line 670 the assert failed because it could not find one. Setting active_menu_ to MAP after the unit facing is set fixes this. 2024-10-20 14:48:31 -05:00
Gunter Labes
4e1666c7a1
autorevision: Revert nonsensical handling of untracked files 2024-10-20 21:18:48 +02:00
newfrenchy83
f7a4041f54
update codeblock libraries 2024-10-20 21:16:40 +02:00
Charles Dang
01efec92fa Display: don't return const map_locations 2024-10-20 01:55:16 -04:00
Charles Dang
c5891ef7fe Display: clean up exclusive draw stuff 2024-10-20 01:54:37 -04:00
Charles Dang
6d40872de0
Display: remove display_context wrapper functions (#9481)
This removes `get_teams()`, `get_units()`, and `get_map()` from the display class. These only served as one of the many, many ways to access this data held by the display_context, and that shouldn't be the first-class responsibility of display. Instead, we either access them through the display_context pointer that display holds (whose getter has been renamed to `context()`) or through other more convenient paths (such as play_controller). The editor_display function `map()` has now taken up the mantle of `get_map()`, mostly because both `display::get_map()` and `editor_display::map()` are used, and the former outnumbered the latter.
2024-10-19 21:38:18 -04:00
Subhraman Sarkar
f2bbedb9bb update markup in time of day help topic generator 2024-10-19 20:32:20 +05:30
Nils Kneuper
940c9abe80 updated Chinese (Simplified) translation 2024-10-19 13:43:36 +02:00
Charles Dang
99f5cfacfb GUI2/Game Stats: take team reference instead of team index 2024-10-18 14:20:07 -04:00
Charles Dang
fc514ccefb Game Display: clean up unused/unnecessary functions
Removed:
- debug_highlight et al. Unused, and we have the main "display coordinates" debug flag in the base class
- current_team_name. Only used in one place, clearer to just call team_name directly.
- get_terrain_on. Unimplemented
2024-10-18 14:19:37 -04:00
Charles Dang
a80831fb9f Format a few more ctor list (no content changes) 2024-10-18 13:12:47 -04:00
Charles Dang
672b33f227 Actions/Undo: use nested namespace declarations 2024-10-18 13:11:35 -04:00
Charles Dang
5e4728d69e Remove make_unit_ptr
Only used in one place anymore which already included unit.hpp anyway, so there's no benefit here.
2024-10-18 12:51:01 -04:00
newfrenchy83
995d67cf77 fix fallaback to unit alignment for filter and formulas. 2024-10-18 12:06:09 -04:00
newfrenchy83
174be0f8c4 Change the alignment code in attack to return an optional value and avoid falling back to neutral alignment when unit alignment is not available. 2024-10-18 12:06:09 -04:00
Ivan A. Melnikov
a1cadb54e5 campaignd: Use completion token overload
... to fix compile issues with boost 1.86.

Commit 9c665ae3c4684f8826f4b7d8e0a75b9a986e8617 does the same
for wesnothd, but campaignd still fails to compile with
overload resolution failure.

References  #9284
2024-10-18 11:41:34 +02:00