I don't like this solution, but it's the quickest way to get the effect back without
A: having to deal with surfaces
B: having to fiddle with color blend modes
C: having to apply the effect both to the base and the overlays (the old surface impl continuously
blit a single surface together so it could just adjust the final product once)
Looks like was a regression from 1135077d16f6e6cba4efab8ea954294d69bb8897.
We didn't need a shrouded check before since the terrain at issue was set to VOID_TERRAIN
if the hex was shrouded, meaning the is-village check would always fail. When we switched
to iterating over the village list directly we made it necessary to check each village loc
for shroud or fog before drawing the indicator.
No translated text yet, just template .po files.
The po files are generated assuming that PR 8433 will merge, removing
the new translatable text from the multiline_text and spinner widgets.
This adds a new missing_mandatory_wml_tag() function, which
returns a message using a common string, similar to the existing
missing_mandatory_wml_key.
To avoid new strings in 1.18, the current implementation
just calls missing_mandatory_wml_key directly.
Subhraman rewrote the scrolling code in the last few commits,
and it seems that the autoscroll check is not needed anymore.
Remove that check altogether and make it 2 argument.
The problem with the 3-argument override was that, when
code in text_box_base.cpp calls the virtual method, it will
only consider the 2-argument version, and thus skip any
3-argument wrapper.
This fixes a Clang warning, although the warning itself points
out the opposite effect - that the 3-argument version hid the
2-argument one in the subclass.
Also fix a Clang warning that scroll_text could mark a method
as an override.
Co-authored-by: Subhraman Sarkar <suvrax@gmail.com>
