The problem was that the specials_context was not set during those
two get_special_bool calls
This removes what seems to be a rather useless optimisation in
battle_context::battle_context since choose_attacker_weapon would
just return 0 in that case.
fixes#2801
(cherry-picked from commit c4cf0c9da4b24589bd34a8aee9b41cda479ff35c)
The problm was that the old code tried to use `undo_stack().can_undo()`
to check whether the current action can be undone. But
`undo_stack().can_undo()` uses the undo stack which is only updated at
the end of each action, so it cannot be used to check whether the action
that is currently executed can be undone.
This code removes some assertion that were wrong due to the
justmentioned.
(cherry-picked from commit 79072b7c3d7ab662f1ca7bb27aa257bf9fd1a9fe)
* Updated changelog style
I have to do that because maximum size for textfield is 1000x1000 so full changelog doesn't fit there
* Disaled Spell Checking and bumped to 1.13.13
(cherry-picked from commit bca6203bf45b44515603918232950a58b3a45cf8)
Taking the chest south of the start hid the door and chest that are
north of the start.
The sneak-door opened much earlier in the level, allowing the undead
from the south-east lich to go north to the spider room. The ghosts
and nightstalkers that are supposed to ambush the player's forces in
the south (after opening the 3-hex door) instead go north and end up
joining the spider fight. The slower-moving undead also go north,
and are easily fought one-by-one in the sneak passage instead of the
south-east.
[ci skip]
(cherry-picked from commit 2caed06cdb0847c7b6d14531647a7b2cbede1505)
This allows having multiple Dockerfile-base-* files without also needing to add a separate Dockerfile-travis-* file due to the FROM line changing.
(cherry-picked from commit 3f67c2fbf051aa9e322defb66c782477cd53b8bd)
This matches with the "Another old caved-in passageway..." event
around line 835, the trigger is on 55,33 and the walls that open are
[terrain]
x=55,55
y=34,35
terrain=Uu
[/terrain]
Debian bug #483893, for which the original fix in
4c473187e658607b17c113d66b2bf549e48e41e5 changed the wrong digit.
This is a cherry-pick from 1.14 to master (fixes#2804) of
bcaac1ef (the change) and 5b7aca97 (the changelog).
[ci skip]
(cherry-picked from commit d6661fdb802a06050a9a76693c40566e9ecbdc10)
this makes more sense as the game cannot handle sycned commands while
executing local choices. It also fixes an OOS in
wesnoth.synchronize_choices
(cherry-picked from commit bce8c29568a0ba28455579e0057180f00bdd9190)
this mainly effects wesnoth.synchronize_choices:
previously the client would not process incoming choices from other
players while it was exeucting its own local choice (usually a dialog).
The problem this commit fixes is that with the old behaviour any choice
from another player would block the incoming queue, in particular
chatmessages after that command would be delayed until the
wesnoth.synchronize_choices is finished.
(cherry-picked from commit edd7a82255e6ec7d8882900e0df56fb3af853436)
* sun-shyde standing animations, draft
* additions to sun-shyde floating animation
* singer defense animation
* defense animations for sun-singer and sun-shyde
* try to make scout less leaning backwards
* champion defense animation
* fixing and rounding out basic animations (esp. wrt to floating/standing) for sun_shyde
(cherry-picked from commit 816dd075dcf36e154475fdd84043680d49ad58c1)
This makes it simpler in the future to have branches that have dependencies that are different from master, rather than having a single image with all necessary dependencies installed, which may at some point end up not being possible to do.
(cherry-picked from commit 1bb5fdf2830515d33793c52f298d305bd12b5a60)
