https://github.com/wesnoth/wesnoth/pull/5481 removed the check that made
wmllint: display on and wmllint: display off necessary.
This PR removes now redundant wmllint comments.
find ./data/ -name '*.cfg' -exec sed -ri '/^ *# *wmllint *:? *display *(on|off) *$/d; s/ *# *wmllint *:? *display *(on|off) *$//' '{}' ';'
The following line was causing a wmllint error because it contains _s:
Irs, book_start Icr^Ii, Irs
"../../data/campaigns/Descent_Into_Darkness/maps/07c_A_Small_Favor3.map", line 10: warning, fog or shroud in map file
As far as I can tell this lines do nothing.
1. `file_handle = None` is NOT how to close a file in python
2. The file handle is already closed due to `with open() as file_handle:`
This commit also adds this information to the startup banner on stderr,
the output of --report, and the Game Version dialog's main UI and
clipboard report.
This is intended to replace uses of config::child that may fail, since we eventually want to get rid
of that ugly "invalid config" and the dreaded "Mandatory child missing yet untested for" error.
Both config::child and config::find_child had new optional throw-if-not-found behavior added, enabled
by an instance of config::throw_when_child_not_found.
* units - set image_icon for sidebar display of Cataphract
* units - remove inactive ability description for Diversion
* add recruit/recall to event list triggering check for diversion animation (Dunefolk Falconer)
* units - north facing bowman and troll whelp
* units - north facing standing and defense frames for dunefolk skirmisher
* units - defense and (half-hearted) dagger attack anims (SE) for poacher
* units - update footpad sprite (SE-only)
* ran wmlindent
* Removed more unnecessary includes
* Used std::swap instead of boost::swap in fake_unit_ptr. This is since unit_ptr (the type of `unit_` here)
is now just a shared_ptr instead of a boost::intrusive_ptr.
* Used std::gcd instead of boost::integer::gcd
Applies (refs to :
* 4a72a9f0ef (we had !=, upstream used >, so I went with the latter)
* 4cf2d589e9 (catalog.hpp only)
* fac4caa4d0
This also fixes builds with /std:c++latest on MSVC. Seems that last commit which fixed things on
GCC9 also fixes thing on MSVC. Not entirely sure why it breaks in C++20 mode where it didn't before,
but potentially something to do with the default constructor and the new concepts stuff.
`requires` is a reserved keyword in C++20 related to the new Concepts stuff, so you can't have a function
named that. Also renamed `conflicts` to `does_conflict` for consistency with the new `does_require`.
