They mostly seem to be code cleanups or style changes, plus the hack to
try to start the irc echo for the old instance after restarting... which
doesn't seem to be working.
* Added code for handling 1.8 and 1.10
* Don't use libana for Wesnoth versions that include it (1.9.x)
* We now use Git, not SVN. The downstream repository is managed
externally, so we need to update a git-new-workdir checkout every
time we want to build.
* Other nondescript changes
(Apologies for the horrible commit message, but it looks like there was
more than my own changes awaiting to be committed.)
This has been around since commit 727294a4b5c72551f559645de504d3a9b8cdf49d
(version 1.5.1) and doesn't serve any purpose nowadays since add-ons
are always stored in gzip format and with the correct encoding.
The method was apparently repurposed a few times to deal with some
encoding issues that cropped up during the introduction of server-side
gzip streams in 1.5.x:
* fdb32be49eb17023364ed2df3d4e60bf582082db "Fixed campaign to use
correct compression level and encoding messages"
* ed564762873d3d8ad043acb720112f92cf848ca3 "Fixed addon server
conversion code for cr encoding"
* f4c62eabe7e4d97eaf4a46edc0f67d75631e2cd1 "Made campaignd server
encode CR in old content that is stored in campaignd"
* efab5f83008b1f9937b1c101a3c1eaff87fd3fd8
All in all, the last time it possibly saw any use for wesnoth.org's
usage was with version 1.6.0, therefore it's safe to get rid of it now.
(The encoded and cr_encoded attributes in the server configuration files
for 1.8, 1.9/1.10, and 1.11 in production have been set to 'yes' for
ages already, which means the method wasn't being run beyond the first
statement on startup anyway.)
The name in the code was icons/icon-title_screen.png, but LordBob
commited it as icons/icon-titlescreen.png instead. Since no other icon
in the directory uses underscores, let's stick to LordBob's spelling.
Fixes a NULL pointer dereference when drawing preview pane overlays in
the Recall Unit dialog for a unit whose overlays list includes an image
that doesn't exist or can't be read, and debug mode is not enabled.
This didn't happen in debug mode because image::get_image() retrieves a
valid placeholder surface (currently images/misc/missing-image.png) in
that situation with debug mode enabled.
Reported by SkyOne in the forums: http://r.wesnoth.org/t39983
Thanks to mattsc for pinpointing the commit at fault.
Note: the code handling overlays on the listbox/menu of the Recall Unit
dialog shouldn't be affected by this since it uses the BLIT image path
function instead of accessing surfaces directly.
This should allow future clients to sort and display add-on
creation/first upload dates by looking at the original_timestamp
field.
NOTE: existing add-ons lack an original_timestamp field. This
functionality only applies to add-ons uploaded for the first
time.