No viable conversion from returned value of type 'basic_string<char, char_traits<char>, allocator<char>>' to function return type 'utils::optional<t_string>'
* Remove STARTING_VILLAGES
There are no villages close enough anyway.
* Fix revealing villages
Use the coordinates of the ogre village instead of what probably were
two removed villages.
* Remove capture of non-existent village
There is no village at 32,13. The nearest one is at 36,11, and it is too
far for Mortic too reach in one turn, so they don't even try.
* Simplify human-meets-ogre event
Instead of repeatedly running FIND_NEARBY, use already assigned unit and
second_unit variables.
* Simplify ogre-meets-ogre event
Use already assigned "unit" variable and find another unit adjacent to
it.
* Fix bugs in Grug-meeets-ogre event
There were two bugs. First, calling FIND_NEARBY with $found_unit as an
argument causes a clash with its internal variable and leads to the
wrong (not nearest) unit being selected. Second, the last message used
$unit instead of $found_unit, which made Grug say this line instead of
the wild ogre.
* Use $this_item instead of $unit in foreach
To avoid clashes with $unit automatically assigned in other events.
* Fix clearing variables
Remove clearing variables that are not actually used, clean those which
are used. Remove elixir_drinker variable from the macro as we use the
trait instead.
* Use $x1, $y1 instead of $unit fields
Makes the code a bit shorter.
* Simplify drake sighted event
Replace FIND_NEARBY with simple condition.
* Rename variables
our_id to our_unit_id, their_id to their_unit_id
I'm not sure I want to keep this API, honestly, but this is the more proper behavior. Before I added precise_subrect, it partially fixed the precision issues I had with the new unit bar rendering.
* SotBE: S12: make loyalists AI smarter
* SotBE S12: run wmlindent
to make it stop pestering me
* SotBE: add missing macro define
Just a temp define until the rework can be released
---------
Co-authored-by: Tahsin Jahin Khalid <5283677+knyghtmare@users.noreply.github.com>
* sotbe: add snow weather sfx to selected scenarios
* SotBE: remove snow weather
the rationale is that the map is not fully snowed in...the snow is around to be 30% at most. So not needed.
---------
Co-authored-by: Tahsin Jahin Khalid <5283677+knyghtmare@users.noreply.github.com>
* Improve Wose Shaman Description
* Furthe Wose Shaman Description Improvements
* Rewrite Wose Shaman description
I tried incorporating some ideas from Dashomew into my own description
* Incorporate some of Dalas's description
* Add Wose Sapling Description
Fixes#7685
This issue I crated has been lying around for a very long time, so I thought I'd try my best to fix it.
* Reduce repetition slightly in Wose Sapling Description
* Incorporate Dala
