82746 Commits

Author SHA1 Message Date
Steve Cotton
35dbaa472e Clarify whether add_source_file should add .hpp files
Only add files that were named on the command line, don't implicitly
add a .hpp file when the .cpp file was given. Previously the script
both needed the .hpp (for Xcode) and failed when the .hpp was given
(for CodeBlocks).

Add the following checks, and if any of them fail exit before making
any changes. Also add a --no-checks option to proceed anyway.

* Check the files exist
* If a .cpp is given and the .hpp exists, check it was given too.
* If a .hpp is given and the .cpp exists, check it was given too.

For the files used by CMake and SCons, .hpp files were never added,
and they still won't be.
2024-01-30 08:41:26 +00:00
Charles Dang
cc4932ea46 Make Ubuntu happier 2024-01-29 23:41:39 -05:00
Charles Dang
3cbe0dcdcc Make Ubuntu happy 2024-01-29 22:32:05 -05:00
Charles Dang
8619e403a8 Game Config: make tc/color_info take a string_view and allow heterogeneous lookup 2024-01-29 21:14:07 -05:00
pentarctagon
f71e0b3b17 add a delay after using scroll.
Fixes #8276
2024-01-29 00:48:06 -06:00
doofus-01
2ed76c9458 fix terrain graphics rule for elevation/ice/water transition 2024-01-28 17:42:38 -08:00
OrekOrek
5043badb34 Fallback deletion
Unnecessary fallback is deleted.
{CLEAR_VARIABLE terrain} is moved to the right place.
2024-01-28 18:49:34 +01:00
OrekOrek
f48a2fbabb HttT S12 Snow falls at a constant pace
Line 227 (original):
Re, Rb are dirt, and these hexes are not converted to snowy terrain. However, by having them within [filter_location], snowfall pace fluctuates. Also, Hhd^Vc doesn't exist on this map.

Line 258~269 (original):
Coa and Hhd are not filtered.

Line306~311 (original)
Hhd^Vc doesn't exist on this map.

These changes make snow fall at a constant pace. Also, unnecessary codes are deleted.
2024-01-28 18:49:34 +01:00
P. J. McDermott
0d99cd045f Revert "Check for correct openssl version."
This reverts commits 7ce1bf9f7da and c6a2dc93175.

OpenSSL >= 3.0 was required (but only when building with CMake) so that
src/preferences/credentials.cpp could use EVP_EncryptInit_ex2() (commit
a880f01a315), but that change was reverted (commit 83ab05532a9), all
within three hours.
2024-01-28 11:27:43 -06:00
Nils Kneuper
88befc29de updated French translation 2024-01-27 20:21:06 +01:00
Nils Kneuper
04596cae74 updated Arabic translation 2024-01-27 20:20:22 +01:00
pentarctagon
dcde7c541e Re-sets the standing animation before and after the temporary_unit_mover moves the unit
Fixes #6960
2024-01-26 16:18:45 -06:00
Elvish_Hunter
10733b1071 wmllint: check if campaigns are in the 'campaigns' folder before considering them as mainline for the rank check 2024-01-26 21:46:37 +01:00
Elvish_Hunter
1c9274faea wmllint: make the 'ignore' magic comment actually work in certain situations
Fixes #8182
2024-01-26 21:31:56 +01:00
Toom
8f01f11065
Remove warning about weapon specials with no name since name is not mandatory 2024-01-26 16:21:15 +01:00
Tahsin Jahin Khalid
75f524fc22
bug_report.yml: change comma to fullstop (#8300) 2024-01-26 09:39:07 -05:00
Steve Cotton
84b1a778ae Backstab unit tests: check that backstab works in a free-for-all
The units on the outsides of a backstab don't have to be allied
to each other, they just have to be enemies of the victim. That's
hardcoded into the AI via attack.cpp's backstab_check() function,
hence a unit test to check that WEAPON_SPECIAL_BACKSTAB activates
in that situation.

Add a new map with 4 sides all on separate castles. This is a
variation of the generic 2p unit test map, extended in the south
with a horizontal reflection of existing map.

Add a MAP_FILE argument to COMMON_KEEP_A_B_C_D_UNIT_TEST,
because it's the same setup except for the map file.
2024-01-26 14:35:07 +00:00
Steve Cotton
866d1a7a6e Use argparse for add_source_file
Treat an argument of "--help" as a request to print help, instead of a filename
to add to the source lists.

Treat the arguments "src/foo.cpp" "src/foo.hpp" as two filenames, instead of
adding src/foo.cpp to target src/foo.hpp. The old command line

    ./add_source_file a b c

becomes

    ./add_source_file a --target b --target c

When saying that pbxproj is required, suggest optionally using a venv instead
of installing systemwide.
2024-01-26 12:03:05 +00:00
PointMeAtTheDawn
4d7aed9c1a Fix Kaleh sword parry 2024-01-25 20:42:06 +01:00
Gunter Labes
395f93d061
Update action versions to use Node.js 20 2024-01-25 12:58:27 +01:00
Dalas121
56cc959d93
EI Shadow Mage, Shadow Lord Balance (#7938)
Original Eastern Invasion rework's Shadow Mage/Lord stats were based on undead's 50% arcane vulnerability. With the arcane rebalance, the Mage/Lord's arcane weapon is almost never worth using.  This commit adjusts the Lord/Mage's arcane/impact weapons.
2024-01-23 09:49:43 -06:00
Gwyn Ciesla
f67fd26ff5
Fix tmpfiles.conf and sysusers.conf paths in SConstruct. (#8280) 2024-01-23 04:07:45 +03:00
demario-w
c873e09a60 Store core ID into save 2024-01-22 16:35:35 +01:00
demario-w
4604c949fa
Add 'k' hotkey to core management window from main screen
Fixes #8209
2024-01-22 16:30:39 +01:00
Nils Kneuper
c9380a960f updated British English translation 2024-01-21 15:04:49 +01:00
pentarctagon
79ca90648a 2024 copyright update - misc 2024-01-20 22:41:50 -06:00
pentarctagon
970163813d 2024 copyright update 2024-01-20 22:22:23 -06:00
pentarctagon
78dff4cf8e 1.17.25+dev 2024-01-20 20:04:23 -06:00
pentarctagon
971e05c63a 1.17.25 1.17.25 2024-01-20 20:02:42 -06:00
pentarctagon
6b3b6511b6 pot-update and regenerate doc files 2024-01-20 20:02:02 -06:00
pentarctagon
118f780f60 changelog_entries 2024-01-20 19:56:52 -06:00
Subhraman Sarkar
18086e78ae
Hotkeys (#8249)
Shortcut keys for map editor
2024-01-20 19:32:31 -06:00
Steve Cotton
255a99782e EI S11: Correct a couple of [message]message= to [message]female_message=
Fixup of ebab1ad8fd0cb180f92e98e4b7f6e28b70d47ddf.
2024-01-21 02:11:11 +01:00
Steve Cotton
87b42c404b Add a unit test for the event-handler reordering bug
This test would fail without the fix from the previous commit.
2024-01-21 01:38:48 +01:00
Celtic Minstrel
508859cfb6 Make a copy of the active event handler list before executing them.
This avoids issues if the events being executed add new handlers, since adding a new handler needs to sort the list according to the event priority.

Fixes #8157
2024-01-21 01:38:48 +01:00
Steve Cotton
91bd96b319 Revert "systemd: drop _ prefix from username"
Prefixing all system and group names with the underscore is
recommended by the systemd developers.

This reverts commit d6d2a4f9967be5cce600d581eabf252138ef79ac.
2024-01-21 01:34:18 +01:00
Hejnewar
b3ec3f4d0b
UtBS Balance (#8269) 2024-01-21 01:15:14 +01:00
Steve Cotton
ebab1ad8fd EI: fix macros in translatable strings, improve po hints
In S11, make the first deserter always male so the translations don't need to
worry about gender variants. However, add gender variants to the strings that
talk to that deserter, as they're new in 1.17.
2024-01-20 23:58:10 +01:00
Eugene
9f99a4ef7d
Simplify nearest neighbor rescale (#8240) 2024-01-20 16:50:14 -06:00
Steve Cotton
c25fc888a7 Make event_test_filter_condition check when the filters run
Also add the missing first_time_only=no, which is why the three [moveto]
events didn't trigger the third event three times.
2024-01-20 23:00:59 +01:00
Celtic Minstrel
b2b2052e78
Update Morogor Dialect notes (#8258)
Address a few weird or problematic entries in the glossary. This also makes it use the term "glossary" instead of "dictionary", as that's what it really is.
2024-01-20 14:20:25 -05:00
Nils Kneuper
46ff2980e7 updated French translation 2024-01-20 14:48:04 +01:00
Nils Kneuper
9506be6f6b added new Finnish translator 2024-01-20 14:48:04 +01:00
Nils Kneuper
c67e4b4c9f updated Finnish translation 2024-01-20 14:48:04 +01:00
Nils Kneuper
8cc86e350c updated Arabic translation 2024-01-20 14:48:04 +01:00
Steve Cotton
286f14657b Handling of RTL in the left pane of the help browser
Fixes the display of topic headings, including unit names, in right to left
languages (Arabic and Hebrew).

The GUI1 menu code is only kept to support one UI feature, the help browser.
However, the code supported multiple columns and multiple things in each
column; to do the latter it handled each column as a string with embedded
separators. To support the help GUI, all that's needed is for each row to have
an indent, an icon, and a text field. Traces of the multiple-column support are
still in the code, but the drawing code is simplified.

The logic for working out whether mouse clicks are on the icon or the text has
moved from the subclass to the main menu class, as it's a subset of the logic
for drawing the UI.

In LTR languages, this looks almost identical.

In RTL languages, the book icons now appear in the right place, and the text
placement is reasonable.
2024-01-20 14:28:16 +01:00
Steve Cotton
69dae9f0a3 Remove code because menu::set_heading and menu::style::scale_images aren't called
Remove some special cases from the drawing code, because menu::draw_row
was previously also used for drawing the headings.

As scale_images was never called, adjust_image_bounds was a no-op.

This is separate from the main dead code removal commit because it touches
active code paths.
2024-01-20 14:28:16 +01:00
Steve Cotton
22c8a1581d Remove dead code from GUI1's menu class
The GUI1 menu code is only kept to support one UI feature, the help browser.
More specifically, the left-hand pane that looks like a treeview.

Remove the code for sorting the list in the UI. The help articles are ordered
by category, and there isn't a UI control for the user to sort them into a
different order.

Remove erase_item(), which wasn't called from anywhere.

Remove clear_item(), recalculate_pos() and assert_pos(). These three were
only called by the sorting code and erase_item().
2024-01-20 14:28:16 +01:00
Pentarctagon
d9aa71ac86
Add missing names to about.cfg (#8260)
Fixes #6475
2024-01-19 16:16:31 -06:00
Toom
8da8b96b07 Set filelist parameter in CrossRefLister constructor call, fixes #7841 2024-01-19 14:20:08 +01:00