This is intended to address concerns raised by @beetlenaut that the two are not young enough to be referred to as 'kids'.
(cherry-picked from commit acb48da5d2115b086f436279dccdef482c89401d)
[ci skip]
Height isn't the problem. The default lobby can display fine even at 600 px h. Width is
the problem the default layout faces at low resolutions, and it was quite odd to have a
really wide window use the low resolution layout, despite there obviously being enough
horizontal space to fit the sidebar.
(cherry-picked from commit 2f565b8e90e9b49a49635034524eb79d29e5f80d)
This is similar to the change made for spacers in da5f00c2b671b79fcec8c36aa5316e1c7663a355.
It also fixes an issue with the MP Lobby chat box (and other such widgets that use formulas
for their fixed dimensions) where it would stay too small after a window resize (the chat
box formulas in all three dialogs it appears in are a percentage of window height).
(cherry-picked from commit 18afe08a7b0646aefdf30bebdabc46d2007208f4)
as is done in rest of wesnothd. This also fixes crash from self-kick
due to it trying to continue processing looking for further tags
after /query kick kicked the user in quesion.
(cherry-picked from commit 6a310f0c79d002cbe53d9ee4f12b95a3b31c721b)
Besides replacing the "End of file" error when getting disconnected from
the server under unexpected circumstances (e.g. because the server died)
with a translatable and more intuitive message, this also makes it so
other network error messages ("Connection refused", "Host not found",
etcetera) are displayed in the UI in a slightly clearer fashion, and in
an error dialog that must be dismissed with a click on a button, instead
of a transient message that can be easily missed due to an accidental
misclick.
Closes#3005.
(cherry-picked from commit c503c2ce35bc7d70fddc71daff70e31389615cf0)
In S03, also removed one extra instance of the word "champion" from the same string.
(cherry-picked from commit 195d5a93db6fbd13f7bc2d41266652fb89549ef8)
The Pango presets are usually a little darker than we want, so this makes the colors POP.
(cherry-picked from commit 3d158130f4f33b518a5e562f85ebc5c182819743)
the for those moves get_unit() might return nullptr when it is
when the future map is not applied and some codes deduced from
that that the action is invalid. So we make sure that code does
not rely on get_unit().
(cherry-picked from commit 04d0dcdf655beefeda3a79d575669789ddc14e3b)
After a recruit action was executed the id of the unit was changed so we
need to update the unitid of all following actions on that unit
(cherry-picked from commit 2174bfc2156fd3af6ceb76e6bb939bc04c27c503)
there have been reported many assertion failures due to get_unit()
returning nullptr, so we try not to rely on get_unit() whenever
possible.
(cherry-picked from commit 5847615a774d8fa7f78be8fbef0ce8ca67fcd909)
i don't really know why the old code had a special case for
`get_turn(next) != turn_of_position`, from what i see `turn_end(0)`
would basicially return the same value as `next`. The new code removes
that special case which resulted in assertion failures before (#1841)
and also consiers the case where `position` appears multiple times in
`turn_beginnings_`
(cherry-picked from commit 195913fc4be356bce2aa5d9b99bc2f64a4c3048b)
the assumption
(turn_beginnings_[num] == it) => (get_turn(it) == num)
might be wrong in case that we have a turn with no actions, in which
case turn_beginnings_ contains duplicates and we actually want the upper
bound of (x <= it) in turn_beginnings_
(cherry-picked from commit ba6495c96addbc8279d580e261acce6b589a6eeb)
