upstream/wesnoth
1
0
Fork 0
mirror of https://github.com/wesnoth/wesnoth synced 2025-05-17 23:15:41 +00:00
Code Issues Packages Projects Releases Wiki Activity
74,768 Commits 52 Branches 374 Tags
Commit Graph

74768 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Severin Glöckner
e5ba221c7a ANL: income lock no longer required 2019-06-14 04:45:16 +02:00
Severin Glöckner
b2b9a90022 ANL: refactor income change 
This opens up the possibility to change the income
 2019-06-14 04:45:16 +02:00
Severin Glöckner
25a5633303 ANL: remove bottleneck from map (spider-area) 
It's not the intention that players hide there for 20 turns without
putting up a fight.
 2019-06-14 04:45:16 +02:00
Severin Glöckner
f11020db51 ANL: avoid unnecessary unstoring 2019-06-14 04:45:16 +02:00
Severin Glöckner
9042ced2a4 ANL: leaders take advantage of player's castles / villages 2019-06-14 04:45:16 +02:00
Severin Glöckner
48e2493359 ANL: disable swamp trick 
- by building a house between the swamp and the guardian the restriction
  could have been bypassed. And because attacking a unit next to the swamp
   has higher priority compared to capturing the house it's not very dangerous
- also use the same macro for guardians and leaders movement restrictions
 2019-06-14 04:45:15 +02:00
Severin Glöckner
e258bea9bd ANL: code cleanup 2019-06-14 04:45:15 +02:00
Severin Glöckner
036d5e0732 ANL: new objectives screen 2019-06-14 04:45:15 +02:00
Severin Glöckner
0263189ea1 ANL: simplified help 
- looks better without image
- no options where they are not needed
 2019-06-14 04:45:15 +02:00
Severin Glöckner
c25c22098e ANL: use unsynced help menu 2019-06-14 04:45:15 +02:00
Severin Glöckner
cf102bd161 manpages: document how to set an empty side 
[ci skip]
 2019-06-14 01:59:20 +02:00
josteph
8fd251b5da statistics: Move the hitrate_t ostream formatter to the correct namespace, to match the declaration. 2019-06-13 19:15:29 +00:00
Steve Cotton
d6cac0c4e7 wmllint: Handle nested events and other things with filters in the death check (closes #4085) 
The main reason for moving this to a separate function was to make the
per-event variables local to that function.

(cherry picked from commit 7e69da7f68b10bdf231ebb785b3c73109dc378a8)
 2019-06-13 19:26:50 +02:00
Steve Cotton
269b89f2e3 wmllint: Make a separate function for checking for units speaking in their die events 
This just moves the existing code, and adds a todo for handling in a later commit.

(cherry picked from commit a3cf683348168619a299c9907fce1d1b4ee9f245)
 2019-06-13 19:26:50 +02:00
Severin Glöckner
055e793da6 wmllint: fix error in orcish leader rules 
introduced in aa71482
[ci_skip]
 2019-06-13 18:27:34 +02:00
Nils Kneuper
fc2ba5be24 updated Turkish translation 2019-06-13 15:21:45 +02:00
josteph
a4da90f921 statistics_dialog: Hide the "This Turn" header when no data is shown in that column 2019-06-13 10:54:52 +00:00
Alexander van Gessel
414160263d Restore 3-significant-digit si_string (closes #3871) 
Behaviour for MSVC remains the same (fixed with 1 decimal).
Fix a corner-case where [999.5, 1000) would not trigger 4-digit precision,
but would be rounded to 1000 during printing, resulting in 1e+3.
 2019-06-11 21:29:29 +02:00
Reuben Rakete
aa901478c2 Fix crash when adding/removing hotkeys with no matches 2019-06-11 14:39:58 +00:00
jostephd
e27ddf7535
Merge pull request #4070 from jostephd/hit-rate-histogram 
Add actual/expected hit count stats to stats dialog
 2019-06-11 08:51:03 +00:00
josteph
68f8e5fb16 fixup! statistics_dialog: Attempt to fix missing left padding before the first column 
Fixes validation errors: "Invalid value '-5' in key 'border_size=' in tag [column]"
 2019-06-11 08:36:15 +00:00
Niall Burton
a471392c37 Fixed weapon specials text not displaying in correct color: Issue #4071 (#4107) 2019-06-08 08:02:17 +03:00
doofus-01
3fb552396b dread bat portrait 2019-06-06 21:42:49 +02:00
doofus-01
5071800a48 adding cuttlefish and bat portraits 2019-06-06 21:42:49 +02:00
doofus-01
c5e5902534 adding new great wolf portrait, re-assigning wolf portrait 2019-06-06 21:42:49 +02:00
doofus-01
311c139203 adding mudcrawler portrait 2019-06-06 21:42:49 +02:00
Alexander van Gessel
f5991ecb48 Add negative support to si_string (closes #1396) 2019-06-06 17:32:11 +02:00
josteph
4fb2aaa7ab Another code style change. 
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087743
 2019-06-05 10:31:10 +00:00
josteph
541956343b Code formatting changes. 
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087376
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087461
 2019-06-05 10:31:10 +00:00
josteph
869c5a43a5 statistics_dialog: More of "Don't reference temporaries". 
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087271
 2019-06-05 10:31:10 +00:00
josteph
d6b30f044d statistics_dialog: Don't reference temporaries. 
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087271
 2019-06-05 10:31:10 +00:00
josteph
111cb0f188 statistics_dialog: Use uppercase for macro arguments. 
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290086918
 2019-06-05 10:31:10 +00:00
josteph
e64c7ed591 statistics_dialog: Attempt to fix missing left padding before the first column 
Currently warns: "error validation: Invalid value '-5' in key 'border_size=' in tag [column]"

... but it looks correct.
 2019-06-05 10:31:10 +00:00
josteph
e2638c9d84 statistics_dialog: Don't show probability of the actual result 
To simplify the stats dialog, show two percentages, instead of three
percentages that add up to 100%.

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r285874571
 2019-06-05 10:31:10 +00:00
josteph
061edc2bb3 statistics_dialog: Restore color in the hits table 
The color scale is reversed between Taken and Inflicted:

Row           Color of "hitting less than actual"    Color of "hitting more than actual"
---           -----------------------------------    -----------------------------------
Inflicted     green to red                           red to green
Taken         red to green                           green to red

This way, in both rows green means "It could have been better" and red
means "It could have been worse". Basically, green means the RNG
favored the enemy sides, and red means the RNG favored the current side.

The _a priori_ probability of the actual result is intentionally left uncolored.
 2019-06-05 10:31:09 +00:00
josteph
a932ebee58 statistics_dialog: Change the percentages in the "Hits" table 
Make the contents of the table cell the same regardless of whether
actual<expected or actual>expected.  For example, 2 hits out of
4 strikes at 70% now shows "8.4%, 26.5%, 65.1%", which are the
probabilities of hitting less than twice, exactly twice, and more than
twice, respectively.

Color has been temporarily removed, will be restored in the next commit.
 2019-06-05 10:31:09 +00:00
josteph
651615f979 statistics_dialog: Deduplicate code. 2019-06-05 10:31:09 +00:00
josteph
d76a7ba5d0 Disable -Wunused-lambda-capture on clang. 
In a nutshell, capturing a local "const constexpr int foo;" variable
with [foo](){} warns on clang that the program would be valid even if
the square brackets had been left empty, but making them so warns on
VC15.  See
https://stackoverflow.com/questions/52416362/unused-lambda-capture-warning-when-capture-is-actually-used

Disable the warning since explicitly capturing foo is good practice.
 2019-06-05 10:31:09 +00:00
josteph
d451238b25 statistics_dialog: Fix wrong uses of linked_group 
Remove extraneous columns, add grids in the bottom two tables where it's
needed for two columns to match the width of one column of the first
table.
 2019-06-05 10:31:09 +00:00
josteph
ea2be9919e statistics: Simplify expression. 
Thanks @jyrkive
 2019-06-05 10:31:09 +00:00
josteph
949d77f950 statistics: Avoid magic strings 
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r283444754
 2019-06-05 10:31:09 +00:00
josteph
584716054a Hit stats: Change serialization keys/values 
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r283119711
 2019-06-05 10:31:09 +00:00
josteph
147f3798cb Hit stats: Use a custom type instead of a pair 2019-06-05 10:31:09 +00:00
josteph
bad65044dc Hit stats: Rename a type to reflect its content rather than its use 2019-06-05 10:31:09 +00:00
josteph
ff5df5141e statistics: Coding style changes suggested by @jyrkive. 2019-06-05 10:31:09 +00:00
josteph
5f34300bf9 Hit stats: Introduce a hitrate_map typedef. 2019-06-05 10:31:09 +00:00
josteph
24b59cb2bf Hit stats: Don't serialize by_cth_inflicted/by_cth_taken 
They're superfluous in the savefile; their values can be deserialized from the
existing [attacks]/[defends] tags and the new [attacks_taken]/[defends_taken]
info.
 2019-06-05 10:31:09 +00:00
josteph
13cf420adb statistics: Add attacks_taken, defends_taken 
They'll be used to reconstruct by_cth_taken, like
attacks_inflicted/defends_inflicted will be used to reconstruct
by_cth_inflicted.
 2019-06-05 10:31:09 +00:00
josteph
479be6e61b statistics: Rename a class member 
To match the convention. The next commit adds the *_taken member.
 2019-06-05 10:31:09 +00:00
josteph
0e3877e3b1 Stats dialog: Add tooltips to the damage and hits tables. 2019-06-05 10:31:09 +00:00