Closes#2914.
This doesn't break the string freeze since it reuses a format string
from the same textdomain required by gui2/game_version for the exact
same purpose.
(cherry-picked from commit fa15142150983162707c7455ae5cc5e917029e96)
This reverts commit 9d0c70fb4861cec7a9f46443f1e59c5ace6ada5d.
That commit was wrong.
std::is_same<char, std::remove_const_t<std::remove_pointer_t<From>>>::value
is not equivalent to
boost::mpl::has_key<boost::mpl::set<char*, const char*> , From>::value
because the former is true not just for 'char*' and 'const char*' but
also for 'char'.
(cherry-picked from commit eacbc5f6959f57ff05451a2874a8e494ac3cb8db)
Turns out remove_const alone only removes the const from the pointer, not from the type
itself, so the expression wasn't returning true. This strips the pointer out before removing
const and matches against char instead of char*
(cherry-picked from commit a7e1ff85ed10fa56512583648727155a54a2b0cd)
This reverts commit 601c67d970c2eacd2c59b340613502de8e8861fe and 98ed802290fb987fc106300a8b6414420e13ba2a.
(cherry-picked from commit 28b1ab286123a415398a3626601642bed51027f0)
The code was checking that the From type was either char* or const char*. Replaced it
with an equality check against char* with the const stripped from From so both match.
(cherry-picked from commit c57a175fee701b4d19c09653a5c9445b778d139e)
Though given 00d87f8fe4078ffd84fcdc0d73fcc2104efef1e7 I would say this is better than nothing.
(cherry-picked from commit 33ad6be326c234b173d680ce34589464f88f8418)
These are used to hide an add-on from listings and deny the author the
ability to upload or delete it or change its passphrase. This is
meant to be used when enforcing add-ons server rules that do not justify
deleting all of the add-on's metadata (for example, issues with icons or
descriptions).
(cherry-picked from commit 7d5d7ee7d429a9d650d300311d2bfeb363ca4686)
This changes the order in which the hook_post_erase hook (currently
unused in production and fully untested) is fired so it will be run
*before* displaying the confirmation message to clients. This might need
to be changed at a later point if the hook functionality ever gets used
again, but for now it'll do.
(cherry-picked from commit 957be8b53edbdce7706491bb4dd7f64de27784a9)
Turns out that commit broke TC on unit images in messages since it broke the equality
check in lua_unit.cpp. Added the XBRZ IPF as part of the Lua unit portrait attribute
instead.
I *think* this is the proper place to do it.
(cherry-picked from commit 98ed802290fb987fc106300a8b6414420e13ba2a)
This reverts commit 0294bd81b21be27e09f10d812fafa6bae7090002.
Changing display is unnecessary when the healed amount itself is forced
to be an integer (next commit).
(cherry-picked from commit f2284e2e79db5432039d0ac0a364d0982c7f9f71)
