The root cause seems to be a parsing issue in Doxygen, described in #6528. So given this isn't our own code and we want to keep the numbner of patches that need to be applied to a minimum, tell Doxygen to ignore the lua source directory entirely.
This does then (somehow) reveal another issue in another unrelated source file where it's referencing a method in its documentation that doesn't actually exist.
Fixes#6528
Includes the correction to the docs.
(cherry picked from commits 3fe24cade94b23c8b60616d41b865ad6dd513571
and e348e6da6b6a6a645071dfb9acda2eb4b3a9b0a5)
This changes it to use the function that attack_type::get_value already uses,
thus removing a call to attack_type::weapon_specials. The latter is being
refactored by newfrenchy83, and questions about the effect of that refactor on
this code delayed the review on his PR.
This code is part of the object used for [filter_weapon]formula=, however the
implementation of that filter creates exactly one attack_type_callable, so
doesn't trigger this code. For testing I called it via a debugger.
Fix another instance of issue #3059, where code assumes that all parts of the
add-ons manager's UI are accessible, an assumption that fails when the dialog
uses a stacked widget to handle small window sizes.
The up and down arrow keys select the previous or next add-on in the list,
even when the small-window layout is hiding the list. That feels like a feature
rather than a bug, as it's useful and an understandable UX; however it needs
the fix in this commit so that on_addon_select() doesn't throw an exception
and close the dialog. The new code is the same as the fix that 050feb623b
applied to on_selected_version_change, traversing the stacked widget to get the
info.
(cherry picked from commit 6a72b2e5114619e7736de97d47a1407254f8fa8a)
The whitespace-fixing script seems to be slightly different depending on the platform.
Even though it produces no effect in the CI, it made these changes locally on my Mac.
I'm committing them now so as to avoid unrelated files being changed in other pull requests.
