(Candidate for 1.10 branch.)
This functionality is back with a slight change to 2010-11-29T19:46:11Z!shadowm@wesnoth.org in order to
left-align the map snapshot only when the leader image cannot be loaded.
We also no longer spam stderr with errors about missing leader images
(which can be caused by unloaded campaigns or eras).
Anonymissimus pointed out this functionality was still found in the GUI2
version of the dialog (--new-widgets). Whoever last changed the saved
games summary code probably only bothered to update this experimental
code without fixing the normal GUI1 dialog. As I pointed out in the
tracker, the layout code was still in place.
As a compromise for the time being, we always assume the "magenta"
palette for TC recoloring now. This doesn't seem to be a problem since
the old code already made an annoying assumption of side 1 using the 1
(red) color range instead of permiting the use of the side.color value,
or reflecting the currently playing side number at the time of the save
generation.
I may later extend the saved games summary to include additional
information to get rid of the magenta and side 1 limitations.
These were the variable substitution delaying in the [object] code. It is
no longer needed due to the workaround [object]delayed_...=yes|no.
Removes repeated WML parsing. Reverts behavior to mostly what was in 1.8
If ABILITY_TELEPORT is added by an [object], or [object][effect][filter]
contains $this_unit, delayed_...=yes is required for the modifications
to work as expected.
However, if the same object wants to get variables substituted and
add ABILITY_TELEPORT to a unit, the code would have worked in 1.8
but doesn't in 1.9.
(bug #18893, bug #19225)
...savegame designation to use Sentence case as the recently
introduced "Test scenario" already does
Also added pofix rule for the two textdomains where this appears.
(It is now impossible to jump to ability topics from the sidebar in
most translations)
Changed all vectors of ability_tooltip objects to be vectors of
t_strings. Previously, sometimes they passed std:string and sometimes
t_strings. This meant that the help index was a t_string->translated
string ->t_string ->base_str(), where the base string was actually a
translated string. The tooltip was passing
t_string->translated_string as index which, although inconsitent
worked.
Now when the tooltip is created it uses the translated string as the
visible string and the base_str() as the index into the help, as
intended but not done in the original code.
Some compilers are calling destructors for static objects before other
static objects use them in their destructors. This patch initializes
static t_interned objects with new and intentionally doesn't call
delete in order to guarrantee their existence throughout the static
de-initialization phase. It creates a new function
generate_safe_static_const_t_interned for this purpose. It might
address bug #18666, although I can not duplicate the crash with gcc on
fedora 15.
1. Changed std::strings to t_token when used as indices.
2. Made a frame_parsed_parameters token resulting in upto 25% memory
savings if unit animations are on for a large variety of units.
1. Added a child_range_index member function to config to generate an index
2. Changed the load dialog from the O(N^2) search for saved games to a
O(N) listing.
...in place of std:string in order to speed up comparisons, copies and
hashing which are 1 cycle operations.
Added z_sub t_token.
Added lru_cache unit test
...otherwise with <600px vertically there will be glitches
the load dialog is a mess anyway and waiting for a rework done in GUI2
once stuff like treeview and such is available
