This includes campaignserver_client.py which is also used by wescamp.py
- however wescamp.py is still Python 2 at this point and will need to be
upgraded at a later point in time.
previously search_in_replay would search for choices in replays even if
it already found all choices. Resulting in error mesages becasue it
finds different unexpected things.
previously replays were broken becasue the game would ask the viewer for
user choices rather than searching for them in the replay.
We fix this by searching in the replay in user_choice_managers
constructor.
The rectangle for the unit_stats was overlapping other rectangles, making
it not function properly. Just resized it to fit. Tested with single
poison effect, both poison and slow, and no effects, all worked.
gna.org/bugs/?23297
If we are waiting for a synced user choice during a prestart events we
now show a gui2 dialog that informs the player about why the client is
waiting and also offers the player the option to quit the game.
The game now shows a notification when waiting for a remove user choice
(like for example a unit advancement choice) for longer than 2 seconds.
This does not work during prestart events yet.
previously there was one function which sometimes returned a wml table
and sometimes a map integer to wml tables dependent on its parameters.
Now there are 2 different functions: wesnoth.synchronize_choice and
wesnoth.synchronize_choices. the first one handles the case where you just
want to get a choice from one side and thus it returns just one wml
table. The second function handles the case where you want to get
choices from multiple sides. that function retruns a table of wml
tables.
I also added an optional string parameter to that function specifying
the type of that choice (this is useful to make replays more robust and
readable)
celticminstrel objects to some of the hyphenation. Geven the American English origin and nature of the majority of the English-speaking Internet, I suppose it's okay to allow American-style compound words where they've already proven dominant in computing/programming/Internet contexts.
One exception here is 'hot seat', where its use has not yet been established in mainstream lanugage.
Also, the made-up phrase 'goto-mode' has had spacing introduced.
celticminstrel suggests the gramatically incorrect 'me and x' form works better in an informal, spoken context so, for the most part, reverting this change.
