22926 Commits

Author SHA1 Message Date
Gregory A Lundberg
6603003e62 DM S19 Fix bug: Kalenz returns in poor shape 2016-10-20 10:49:36 -05:00
Gregory A Lundberg
e59cb908e0 DM S19 Bring out your dead
Recall all Delfador's undead units so he is speaking to all of them when releasing them.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
afe5fc1ca2 DM S19 Kalenz is available
The [if] is meaningless. The death of Kalenz is a defeat; he will always be around on victory.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
7215b4403b DM S19 Fix bug: Defeat on undead death
Defeat should only occur when there are no more undead available to Delfador.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
e83101a785 DM S19 Fix bug: Mismatched shroud
Place and remove the shroud from both sides 1 and 2 consistently.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
17a7664f09 DM S18 Highlight Iliah-Malal
Add leader-expendable and ellipse-hero to mark him. I would have preferred the gold leader overlay but could not find it and making him a leader causes the AI to take him to a keep instead of treating him like any other Lich unit.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
aaaaa7ee3b DM S16 Fix bug: Unexplained gold 2016-10-20 10:49:36 -05:00
Gregory A Lundberg
0e51165808 DM S15 Chantal already recalled 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
87a0212da4 DM S14 Fix bug: Clear fog around Delfador 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
f62cec9865 DM S14 Fix bug: Rudimil might be dead
Use one of the other leaders to announce the arrival of reinforcements.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
a509035767 DM S13 Fix bug: Chantal moves properly
When last seen Chantal was south-west. Have her enter from that direction and run directly to Kalenz. Originally, she appeared in the middle, ran left, ran right, bumped into the edge and stopped; and, usually, Kalenz would be far away from there.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
4079814228 DM S13 Fix bug: Chantal returns in poor condition 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
971353580c DM S13 Fix bug: Disallow recalls
The play has recalls (although not on the list). Disallowing recalls recognizes this with a more appropriate error message.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
f86b3c99dd DM S12 Fix bug: Inconsistent objectives 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
9faeaf561b DM S12 Fix bug: Arpus may be dead
It is remotely possible Arpus may be dead prior to moving to wake the Mages. In fact, they may all have died. Appoint a replacement from the highest-level survivors (if any).
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
3cf1e5a8e9 DM S12 Fix bug: Niktor may be dead
It is possible Niktor was killed before meeting the loyalists. If so, appoint a replacement from the highest-level survivors.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
c5e60b8460 DM S12 Fix bug: No objectives change
Capturing villages inside the garrison should change objectives if they have not done so already.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
0229a24e05 DM S12 Fix bug: Objectives already changed
Capturing the village near Delfador's encampment changes objectives. They also change if orcs or undead are seen, or the Loyalists met; but that change is a duplicate. Remove the duplicated change.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
f2d6a00a8d DM S12 Fix bug: Delfador knows about undead
He should not ask about the abominations.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
997887cdde DM S12 Fix bugs: Several errors with Mages
Apparently, the Mage keep was moved. The scroll position was not updated, nor were the AI parameters to keep the Mages near their keep.

The fog does not lift to expose the Mages, and the narrator's instructions are incorrect.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
b5608d032d DM S11 Fix bug: Inconsistent objectives 2016-10-20 10:49:34 -05:00
Gregory A Lundberg
80d15ec198 DM S11 Fix bug: No recruits before Chantal
Delfador should not gain the ability to recruit Elves until he actually meets Chantal.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
fe8d088fd3 DM S11 Fix bug: Chantal defeat
It is remotely possible Chantal dies before Delfador meets her. Remove her death as a defeat condition until he does.

The goal is to find her before time runs out. If she dies before being found, time will run out.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
e208f01770 DM S11 Fix bug: Disallow recalls
Delfador has recalls (although not on the list). Disallowing recalls recognizes this with a more appropriate error message.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
e2610748e1 DM S10 Animate gate opening
The original intent clearly was to see the gate opening. Added some redraws to make this happen. The result seemed off so added more shaking. It's a bit slower than I'd like but looks good.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
604f2a03d4 DM S08 Fix bug: Remove Delfador visual artifact
Send Delfador to his recall list to remove him before the final fade-to-black frame. This removes the glitchy artifact, making the screen fully black.

Since Delfador may be injured, and will have used moves, restore him to full moves and full health since, otherwise, he will begin the next scene incorrectly.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
eee8744458 DM S08 Fix bug: Withdraw units at correct time
Delfador's Wesnoth veterans withdraw from the field too early, and the Wose too late. Have them withdraw just before the narrator says they do, so if the player glances at the map they are gone.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
23d1582739 DM S07 Fix bug: Always early completion
The skeleton generators turned off on turn 12, always leading to an early-completion on turn 13. Don't turn them off. This allows normal turns-over completion after 14 turns, as designed.

Note than if the generators are taken out, and all skeletons killed, the player must wait for the next turn for victory. This can be rationalized by Delfador's statement indicating he is not sure his solution will work until the next turn, when no skeleton appears.

The use of an invalid tile to record the state of each generator caused errors generating the preview minimap when loading a turn.  Changing the tiles also caused visual artifacts. Eliminated the custom tiles and use event management to handle the generator state.
2016-10-20 10:49:33 -05:00
Gregory A Lundberg
ee2d3999b7 DM S06 Use gold.ogg sound
Implement a TODO. Play gold.ogg after open-chest.wav when taking the chest left by the bandit.
2016-10-20 10:49:33 -05:00
Gregory A Lundberg
529ce87160 DM S03 Use new role features
On turn 4, no need to search the recall list. If there is no bowman for the role, the line may be omitted.

On victory, there may be no surviving bowman. The lines cannot be omitted. Recall a bowman from the recall list, or recruit a replacement.
2016-10-20 10:49:33 -05:00
Gregory A Lundberg
26a238e8f7 DM Remove variable artifacts
Remove variables when no longer needed. Some were never used. Found a few which were cleared but never set.
2016-10-20 10:49:33 -05:00
Gregory A Lundberg
8de87a2f65 DM [if] must have [then] 2016-10-20 10:49:33 -05:00
Gregory A Lundberg
d243b7ce2e DM Remove macro artifacts
Keep local macros local to prevent surprises later.
2016-10-20 10:49:33 -05:00
Gregory A Lundberg
b0c06d077d DM Remove unused macro
In utils/misc.cfg MEMOIRS_SIDEKICK is not used.
2016-10-20 10:49:33 -05:00
Charles Dang
41672422a6 Colorize spacer lines 2016-10-21 02:43:39 +11:00
mattsc
f2406ac829 Experimental AI: correctly deal with hidden and petrified units 2016-10-19 07:37:19 -07:00
Charles Dang
339b4f3ee1 Enabled some commented out tooltips now that bug #22176 is fixed 2016-10-19 22:36:57 +11:00
Nils Kneuper
a094a5fe61 updated list of Finnish translators 2016-10-19 10:10:48 +02:00
Gregory A Lundberg
f4e2cc6681 Fix a unit test
For some reason the macro RESULT causes the test to crash Lua.

Don't see why. Don't know why this fixes it. But this gets the tests working.
2016-10-18 09:01:45 -05:00
Gregory A Lundberg
f805494603 Ensure [endlevel] only happens once.
First come, first served.

This was causing many failures on Travis/CI
2016-10-18 00:35:00 -05:00
Charles Dang
e8a499fcec Merge pull request #822 from GregoryLundberg/GL_Upgrade_Lua
Upgrade to Lua 5.3.3+
2016-10-18 12:58:12 +11:00
mattsc
1bed30c8c3 High XP Attack CA: respect the attacks aspect 2016-10-17 17:59:03 -07:00
mattsc
a333b9a5b7 High XP Attack CA: correctly deal with hidden and petrified units 2016-10-17 17:59:03 -07:00
mattsc
12b03397a9 TRoW S15: make custom AI robust against ambushes 2016-10-17 17:59:03 -07:00
mattsc
d99ee0fc88 Lurkers MAI test scenario: keep side leaders hidden after reload 2016-10-17 17:59:02 -07:00
mattsc
ba6973f543 High XP Attack CA test scenario: use new syntax for [option] 2016-10-17 17:59:02 -07:00
Celtic Minstrel
e81131fcc5 Add deprecation messages for old AI aspect fetchers
This commit also updates uses of these fetchers in mainline Lua code.
2016-10-17 14:24:51 -04:00
Gregory A Lundberg
fc6774289e Upgrade deprecated Lua
loadstring was removed, load does the same thing.
atan2 was remvoed, atan works instead
2016-10-17 10:34:43 -05:00
Charles Dang
1964d71023 Updated GUI2 schema for fb6c85e70b0c 2016-10-18 00:59:22 +11:00
Charles Dang
8a9d546e27 Slight contrast bump to swamp water 2016-10-17 18:22:02 +11:00