I don't like this solution, but it's the quickest way to get the effect back without
A: having to deal with surfaces
B: having to fiddle with color blend modes
C: having to apply the effect both to the base and the overlays (the old surface impl continuously
blit a single surface together so it could just adjust the final product once)
Looks like was a regression from 1135077d16f6e6cba4efab8ea954294d69bb8897.
We didn't need a shrouded check before since the terrain at issue was set to VOID_TERRAIN
if the hex was shrouded, meaning the is-village check would always fail. When we switched
to iterating over the village list directly we made it necessary to check each village loc
for shroud or fog before drawing the indicator.
No translated text yet, just template .po files.
The po files are generated assuming that PR 8433 will merge, removing
the new translatable text from the multiline_text and spinner widgets.
This adds a new missing_mandatory_wml_tag() function, which
returns a message using a common string, similar to the existing
missing_mandatory_wml_key.
To avoid new strings in 1.18, the current implementation
just calls missing_mandatory_wml_key directly.
Subhraman rewrote the scrolling code in the last few commits,
and it seems that the autoscroll check is not needed anymore.
Remove that check altogether and make it 2 argument.
The problem with the 3-argument override was that, when
code in text_box_base.cpp calls the virtual method, it will
only consider the 2-argument version, and thus skip any
3-argument wrapper.
This fixes a Clang warning, although the warning itself points
out the opposite effect - that the 3-argument version hid the
2-argument one in the subclass.
Also fix a Clang warning that scroll_text could mark a method
as an override.
Co-authored-by: Subhraman Sarkar <suvrax@gmail.com>
When reverting this revert (after 1.18 has branched), the
new .hpp file should be added to XCode and CodeBlocks.
This reverts PR #8396, PR #8407 and the "Small fixup" commit;
they bumped the minimum compiler version from GCC 7 to 8 or 11.
This reverts commit 870eeff8e68de000bbe6608c2b6f982b28a2200f.
This reverts commit 029136b19acf9627170e9ab9383cea48b7d70a81.
This reverts commit d74ff6f31b3668d07236ffaa4059f31c373d4996.
This reverts commit 8a6de95d489b4e96d2c9a368b25a0c20e249cdf6.
This reverts commit d14d233d79957ddfcbe200d21f16ab78915c883b.
This reverts commit 698f5c115c1546e3fcf1c52be90d72a5a841abb6.
Adjust Fighter line to allow for easier early leveling and more late game staying power. Add parry to secondary melee attacks in order to incentivise their use.
Has a few updates to S04a, S04b, S09 and S99 too.
Lore: this declares Khrakrahs (dragon seen in SoF) to be male.
He's been in many versions of Wesnoth that only had male drakes,
thus will surely already be male in any translation where the
gender has an effect on the wording.
There's a few "TODO for 1.19" comments added:
* In S12, the left behind units say "we must ride ... to save Wesnoth",
but it should be "you must ride".
* The intro of S13 is confusing, there's little indication of why you
only have one unit, or what mission he failed.
* In S16, Gweddry says "night approaches" on turn 1 (morning)
