this field is intended to allow battles to continue after the death of a leader
if a side has this flag enabled and any units alive, they will be considered
to have a leader regardless of canrecruit.
in the refactor of mp_connect, one behavior from 1.10 that was
lost was that the host may not start a game until all sides have
chosen faction. we restore this, adding fields to the side engine
to fix in a robust manner, some debugging capabilities left over.
This is to restore some functionality that was lost in 2012-11-28T20:26:33Z!jt_coding@verizon.net.
Doesn't have mainline use, but anonymissimus has a use case, so this
replaces the old hacky approach.
We are deleting the captured village from the set of owned villages of
the previous owner before querying which previous side owned it (and
giving it to the new side + firing the event), thus the result was
always "unowned".
fix for a bug reported in the forums:
http://forums.wesnoth.org/viewtopic.php?f=21&t=36569&p=525789#p525789
This was holding data about which side has already seen which
other side. Probably a left over thing from someone
who wanted to implement something at some spot. It also wasn't saved
in the savegames (surely needed).
1. The internal type is a std::string, the lua getters/setters should
reflect that like all the existing ones already do instead of making
implicit conversions.
2. It doesn't make sense to convert the already translated string
into a t_string again upon getting it.
3. The setter in team.cpp you added is redundant.
4. The attribute is apparently not really meant to be modified
by lua or wml so a tag is no good idea.
Some compilers are calling destructors for static objects before other
static objects use them in their destructors. This patch initializes
static t_interned objects with new and intentionally doesn't call
delete in order to guarrantee their existence throughout the static
de-initialization phase. It creates a new function
generate_safe_static_const_t_interned for this purpose. It might
address bug #18666, although I can not duplicate the crash with gcc on
fedora 15.
...of config::attribute_value & to tstring & or t_token reference
causes crashes. Some compilers were generating a temporary object and
binding a reference to the temporary when creating an implicit cast to
an attribute value. I removed the implicit cast and replaced all (I
think) instances of the implicit cast with explicit 2 step operation.
This fixes bugs like bug #18663, bug #18684
