this operator was confusing because usingn map[i][j] would mean that the
border_size is added to x but not to y, It is better to use
operator[](map_location) or to use tiles_[x][y] directly so that this
issue doesn't appear.
we now read the config into objects at the start of that method, this means
that we don't have to do those lookups inside that loop anymore.
This also allows us to change that parameter of that function from config to
std::vector<overlay_rule> later when we want to use that
function from non-wml code.
This also adds a 'color' parameter to wesnoth.float_label. It was already
previously possible to set a labels color using pango markup, but to
implement [unstore_unit] i need to support the color= syntax as given
by [unstore_unit]
This also adds a 'fire_event' parameter to wesnoth.put_unit to specify
whether the 'unit_placed' event is fired, this is needed to implement
fire_events=yes/no in [unstore_unit] but its also generally useful
for the same reason why [unstore_unit] has this parameter.
wesnoth.select_hex has problems with simply highlighting units without displaying
their movement range. If you set its third argument to false, the unit gets
selected, but no hex cursors appears around it. Using this allows us to simply
highlight a location with the hex cursor, independent of unit presence (select_hex
works funny if no unit is present).
Apparently, the manual rect calculations sometimes (eg, with the Progress Bar widget)
resulted in incorrectly placed rectangles being drawn. Using the bare dimension
values fixes this problem.
This function's contents were SDL1.2 only, and in SDL2 only return NULL. This
resulted in create_optimized_surface() always returning the passed surface and
get_surface_portion() to potentially return NULL erroneously (if optimize_format
was true, which doesn't seem to be the case anywhere).
However, there haven't been any discernible bugs that resulted from either of these
behaviors, so it should be investigates whether create_optimized_surface() is still
necessary, since it's been operating for a while now simply returning its passed
surface.
These files were used to provide a compatability layer between SDL1.2
and SDL2 for the hotkeys implementation. As SDL1.2 was taken out,
these files were now empty and superfluous.
