Testing now, pango weight markup correctly works with the Lato weight variant files present and breaks with them missing. Seems the issue I documented back in 2018 is noo longer the case, and thus we don't need this workaround.
This was first added by mordante in a36e1ee696. The code around it was subsequently removed in b217903c07, and had since remained functionally useless.
It was briefly called to action as part of #8510 (see 9b38089db0), but that usecase was temporary and the hardcoded max width subsequently removed in 4cb9df8e6c.
TDG S06 requires the player to both rescue Asheviere and also survive until turns run out.
With this commit, re-show objectives after rescuing Asheviere, and strikethrough the completed ones.
Indentation was fixed by adding a newline to constructs with excessive density
and running wmlindent again. While the constructs were not particularly
readable it wouldn't hurt if wmlindent would cope a bit better.
The help browser now uses the standard title definition. This makes its appearance consistent with other title elements in that theme. Before, it had the wrong color in the celes theme and was the only title in the parchment theme using the script font.
For some reason, if we store a t_string in the class and attempt to parse it later, it breaks text boxes (text will be there but not render) (see #9995). Using an std::string does not have that problem. I don't know why.
I considered a variant<typed_formula, t_string>, but since attribute_value is a variant under the hood, it seemed simpler to just use it directly. If that turns out to be a performance hit, we can deal with that later...
Closes#10001
Corrects a mistake I made way back in dcb996566e, which was that a tip is supposed to be shown if you encounter *any* of the filter units, not *all* of them.
- Side 2 will be less reckless and more defensive
- Side 3 will avoid making stupid moves, like placing units on water for easy kills
Co-authored-by: Tahsin Jahin Khalid <5283677+knyghtmare@users.noreply.github.com>
