...for string representations of genders.
This is probably at best an immeasurably small optimization, but maybe
it will save a typo at some point in the future.
...that determines the unit's gender, not what might be overridden in
the final (gender-specific) type. So a correct test for there being
more than one gender should check the originally specified unit type,
not the resulting unit type.
This is so that replays will be able to accurately replay delayed
shroud updates. (Using the undo stack could have been restricted to
teams using fog or shroud, but it is simpler to just generate the
stack for everyone.)
This is to avoid potential name clashes with any classses named
"action", like what shadowm found in the test suite. (The quick fix of
2012-12-31T05:35:28Z!jt_coding@verizon.net is now reverted in favor of this fix.) One complication
is that there is already an "ai:actions" namespace, so within the "ai"
namespace, the renamed namespace is qualified as "::actions".
...fields and implement a button to toggle them all at once
Also needed to do some refactoring to achieve the tracking part. Not
that anyone really needs to see that in a separate commit.
...for the areas containing the type checkboxes and the status listbox
The previous grid layout seemed strictly presentational and rather
unhelpful from an organizational/semantic standpoint. The new layout
should also make a couple of upcoming changes to the dialog's widget
arrangement and contents easier to implement.
...from non-editable textboxes
This effectively removes the selection/cursor manipulation part of
2012-12-23T06:10:31Z!shadowm@wesnoth.org. Without obvious visual cues as to what textbox has the current
focus it is only good for confusing users. Additionally, at least two
existing GUI-based IRC programs seem to do without selection/cursor
manipulation on the channel/query view box.
...(actually quadruplicate) events. Changed from 2012-12-23T06:10:46Z!shadowm@wesnoth.org.
Due to the way focusing works, the focus switch in the middle of the
forwarding action would create a duplicate event for the origin textbox,
resulting in a duplicate event for the target (a total of four events to
process).
Instead, make the implementation of gui::textbox::handle_event()
forwarding-aware, and provide a wrapper for the events engine
implementation to use by default.
